Bug 2001523: Set Available condition to False when console-operator in Removed state

[jhadvig]

We should report Available condition set to False when operator is in Removed state.

/assign @spadgett

[openshift-ci]

@jhadvig: This pull request references Bugzilla bug 1994443, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1994443: Set Available condition to False when console-operator in Removed state

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jhadvig: This pull request references Bugzilla bug 2001523, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

Bug 2001523: Set Available condition to False when console-operator in Removed state

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/cherry-pick release-4.9

[openshift-cherrypick-robot]

@jhadvig: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/retest

[openshift-ci]

@jhadvig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-operator	03d6f78	link	/test e2e-aws-operator
ci/prow/e2e-aws-single-node	03d6f78	link	/test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[spadgett]

@wking Can you confirm this is the right behavior?

We should confirm setting "Available: false" doesn't block upgrades when console is removed.

[wking]

We should confirm setting "Available: false" doesn't block upgrades when console is removed.

Setting Available: False will absolutely block updates, and fire off critical alerts, and all sorts of bad things. Please don't do that ;). openshift/api#1000 is my in-flight effort to clarify these condition semantics. Applied to this case, if the user asked you to remove your operand, and you have successfully removed it, then you are Available: True, meaning "everything my component is configured to be doing, it's successfully doing".

[spadgett]

Setting Available: False will absolutely block updates, and fire off critical alerts, and all sorts of bad things. Please don't do that ;). openshift/api#1000 is my in-flight effort to clarify these condition semantics. Applied to this case, if the user asked you to remove your operand, and you have successfully removed it, then you are Available: True, meaning "everything my component is configured to be doing, it's successfully doing".

Thanks, @wking. Closing the PR.

/close

[openshift-ci]

@spadgett: Closed this PR.

Details

In response to this:

Setting Available: False will absolutely block updates, and fire off critical alerts, and all sorts of bad things. Please don't do that ;). openshift/api#1000 is my in-flight effort to clarify these condition semantics. Applied to this case, if the user asked you to remove your operand, and you have successfully removed it, then you are Available: True, meaning "everything my component is configured to be doing, it's successfully doing".

Thanks, @wking. Closing the PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jhadvig: This pull request references Bugzilla bug 2001523. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 2001523: Set Available condition to False when console-operator in Removed state

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.