Skip to content

Fix flexible scaling tests #10006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
afreen23 wants to merge 1 commit into from
Closed

Fix flexible scaling tests #10006

afreen23 wants to merge 1 commit into from

Conversation

@afreen23
Copy link

@afreen23 afreen23 commented Sep 7, 2021 •
edited
Loading

Merge after #10005

  • introduce a test case for flexible scaling to be always enabled for a no-provisioner storage class
  • this BZ https://bugzilla.redhat.com/show_bug.cgi?id=2000573 introduced a regression due to the missing test case
  • the flexible scaling feature is only supported now for attached devices mode

@afreen23
Copy link
Author

afreen23 commented Sep 7, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2021
@openshift-ci openshift-ci bot requested review from cloudbehl and shyRozen September 7, 2021 10:36
@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2021
@afreen23 afreen23 force-pushed the fix-flexible-scaling-tests branch from 7986e2f to ae37843 Compare September 7, 2021 13:04
@afreen23
Copy link
Author

afreen23 commented Sep 7, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2021
(test): Update flexible scaling unit tests
90f786b 
 - introduce a test case for flexible scaling to be always enabled for a no-provisioner storage class
 - this BZ https://bugzilla.redhat.com/show_bug.cgi?id=2000573 introduced a regression due to the missing test case

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@afreen23 afreen23 force-pushed the fix-flexible-scaling-tests branch from ae37843 to 90f786b Compare September 7, 2021 15:25
@GowthamShanmugam
Copy link
Contributor

GowthamShanmugam commented Sep 7, 2021

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, GowthamShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 7, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 7, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 6, 2021

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 5, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 5, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 4, 2022

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Feb 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2022

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@GowthamShanmugam GowthamShanmugam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@afreen23 @GowthamShanmugam @openshift-bot