Skip to content

Bug 2006308: Backing Store YAML tab on click displays a blank screen on UI #10119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 27, 2021
Merged

Bug 2006308: Backing Store YAML tab on click displays a blank screen on UI #10119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions frontend/packages/ceph-storage-plugin/console-extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,40 +152,40 @@
{
"type": "console.page/route",
"properties": {
"path": "/odf/resource/:resourceKind/:resourceName",
"path": "/odf/resource/noobaa.io~v1alpha1~BackingStore/create/~new",
"exact": true,
"component": {
"$codeRef": "resourceDetailsPage.GenericDetailsPage"
"$codeRef": "bsCreate.default"
}
}
},
{
"type": "console.page/route",
"properties": {
"path": "/odf/resource/noobaa.io~v1alpha1~BackingStore/create/~new",
"path": "/odf/resource/noobaa.io~v1alpha1~NamespaceStore/create/~new",
"exact": true,
"component": {
"$codeRef": "bsCreate.default"
"$codeRef": "nssCreate.default"
}
}
},
{
"type": "console.page/route",
"properties": {
"path": "/odf/resource/noobaa.io~v1alpha1~NamespaceStore/create/~new",
"path": "/odf/resource/noobaa.io~v1alpha1~BucketClass/create/~new",
"exact": true,
"component": {
"$codeRef": "nssCreate.default"
"$codeRef": "bcCreate.default"
}
}
},
{
"type": "console.page/route",
"properties": {
"path": "/odf/resource/noobaa.io~v1alpha1~BucketClass/create/~new",
"exact": true,
"path": "/odf/resource/:resourceKind/:resourceName",
"exact": false,
Copy link
Contributor

@bipuladh bipuladh Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making this one change. Should be enough right? Why are we changing the order of the extension declaration?

Copy link
Contributor Author

@SanjalKatiyar SanjalKatiyar Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it will affect.
This BZ will work fine even if we do not change the order. But, it will create a new bug instead.
Let's suppose I clicked on the "Create Backing Store" button on the list page. It will check all the available Routes. If this Route (with exact = false) is defined before the Route for creating backing-store component then this Route will be matched (because we are using exact = false here) and it will not load create-backing-store specific component.

"component": {
"$codeRef": "bcCreate.default"
"$codeRef": "resourceDetailsPage.GenericDetailsPage"
}
}
},
Expand Down