Bug 2006060: Redirect to object dashboard for MCG only #10362

SanjalKatiyar · 2021-10-29T13:44:30Z

This PR incorporates a correction to #10117 which got missed when patch #10117 was sent.

Correction: For MCG only system, CEPH_FLAG was getting set as undefined instead of false.

openshift-ci · 2021-10-29T13:44:38Z

@SanjalKatiyar: This pull request references Bugzilla bug 2006060, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (musoni@redhat.com), skipping review request.

Details

In response to this:

Bug 2006060: Redirect to object dashboard for MCG only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-10-29T13:45:30Z

@SanjalKatiyar: This pull request references Bugzilla bug 2006060, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (musoni@redhat.com), skipping review request.

Details

In response to this:

Bug 2006060: Redirect to object dashboard for MCG only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-10-29T13:45:50Z

@SanjalKatiyar: This pull request references Bugzilla bug 2006060, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (musoni@redhat.com), skipping review request.

Details

In response to this:

Bug 2006060: Redirect to object dashboard for MCG only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23

When creating mcg standalone, add these flags.

afreen23 · 2021-11-02T05:10:29Z

frontend/packages/ceph-storage-plugin/src/features.ts

@@ -173,6 +173,7 @@ export const detectComponents: FeatureDetector = async (dispatch) => {
        const noobaaSystems = await k8sList(NooBaaSystemModel, { ns: CEPH_STORAGE_NAMESPACE });
        if (noobaaSystems?.length > 0) {
          dispatch(setFlag(MCG_FLAG, true));
+          if (!cephFound) dispatch(setFlag(CEPH_FLAG, false));


This flag should also be dispatched when clicking creation of a mcg standalone storage system/

It will be set as false here only (for mcg standalone or any other deployment), as soon as noobaaSystem is found and no cephSystem is found. Is there some condition or some place missing where it will not be set ?

added it in footer file, let me know if I should remove it from here or not ?

afreen23 · 2021-11-03T12:40:44Z

frontend/packages/ceph-storage-plugin/src/components/dashboards/odf-system-dashboard.tsx

@@ -29,7 +29,8 @@ const ODFSystemDashboard: React.FC<ODFSystemDashboardPageProps> = ({
  const isObjectServiceAvailable = useFlag(MCG_FLAG);
  const isCephAvailable = useFlag(CEPH_FLAG);
  const { systemName } = rest.match.params;
-  const dashboardTab = isCephAvailable === false && isObjectServiceAvailable ? OBJECT : BLOCK_FILE;
+  const dashboardTab =
+    !!isCephAvailable === false && isObjectServiceAvailable ? OBJECT : BLOCK_FILE;


I think the fix your BZ would be suffice by this ?
undefined is a falsy value.

Suggested change

!!isCephAvailable === false && isObjectServiceAvailable ? OBJECT : BLOCK_FILE;

!isCephAvailable && isObjectServiceAvailable ? OBJECT : BLOCK_FILE;

openshift-ci · 2021-11-03T13:24:36Z

@SanjalKatiyar: An error was encountered querying GitHub for users with public email (musoni@redhat.com) for bug 2006060 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 2006060: Redirect to object dashboard for MCG only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23

/lgtm

The second commit ef9afe7 is just clean up.
The fix is in actual first commit bbe9b77

openshift-ci · 2021-11-03T13:31:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [afreen23]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-11-03T17:48:20Z

@SanjalKatiyar: All pull requests linked via external trackers have merged:

Bugzilla bug 2006060 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2006060: Redirect to object dashboard for MCG only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 29, 2021

openshift-ci bot requested review from cloudbehl and shyRozen October 29, 2021 13:46

openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Oct 29, 2021

afreen23 suggested changes Nov 2, 2021

View reviewed changes

SanjalKatiyar force-pushed the ceph_flag_undefined branch from 7811dbc to 46d60cc Compare November 3, 2021 07:38

SanjalKatiyar requested a review from afreen23 November 3, 2021 07:39

SanjalKatiyar force-pushed the ceph_flag_undefined branch from 46d60cc to ee0e9f1 Compare November 3, 2021 12:26

afreen23 reviewed Nov 3, 2021

View reviewed changes

SanjalKatiyar force-pushed the ceph_flag_undefined branch from ee0e9f1 to 0597cfd Compare November 3, 2021 13:02

SanjalKatiyar requested a review from afreen23 November 3, 2021 13:06

SanjalKatiyar added 2 commits November 3, 2021 18:51

redirect to object dashboard for MCG only

bbe9b77

remove un-used queries

ef9afe7

SanjalKatiyar force-pushed the ceph_flag_undefined branch from 97c5703 to ef9afe7 Compare November 3, 2021 13:22

afreen23 approved these changes Nov 3, 2021

View reviewed changes

openshift-ci bot assigned afreen23 Nov 3, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2021

openshift-merge-robot merged commit 0140984 into openshift:master Nov 3, 2021

SanjalKatiyar mentioned this pull request Nov 11, 2021

Bug 2022446: Fix issue with standalone dashboards (4.9 backport) #10441

Merged

spadgett added this to the v4.10 milestone Dec 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2006060: Redirect to object dashboard for MCG only #10362

Bug 2006060: Redirect to object dashboard for MCG only #10362

Uh oh!

SanjalKatiyar commented Oct 29, 2021 •

edited

Loading

Uh oh!

openshift-ci bot commented Oct 29, 2021

Uh oh!

openshift-ci bot commented Oct 29, 2021

Uh oh!

openshift-ci bot commented Oct 29, 2021

Uh oh!

afreen23 left a comment •

edited

Loading

Uh oh!

afreen23 Nov 2, 2021

Uh oh!

SanjalKatiyar Nov 2, 2021 •

edited

Loading

Uh oh!

SanjalKatiyar Nov 3, 2021

Uh oh!

afreen23 Nov 3, 2021

Uh oh!

openshift-ci bot commented Nov 3, 2021

Uh oh!

afreen23 left a comment •

edited

Loading

Uh oh!

openshift-ci bot commented Nov 3, 2021

Uh oh!

openshift-ci bot commented Nov 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	!!isCephAvailable === false && isObjectServiceAvailable ? OBJECT : BLOCK_FILE;
	!isCephAvailable && isObjectServiceAvailable ? OBJECT : BLOCK_FILE;

Bug 2006060: Redirect to object dashboard for MCG only #10362

Bug 2006060: Redirect to object dashboard for MCG only #10362

Uh oh!

Conversation

SanjalKatiyar commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 29, 2021

Uh oh!

openshift-ci bot commented Oct 29, 2021

Uh oh!

openshift-ci bot commented Oct 29, 2021

Uh oh!

afreen23 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

afreen23 Nov 2, 2021

Choose a reason for hiding this comment

Uh oh!

SanjalKatiyar Nov 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SanjalKatiyar Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

afreen23 Nov 3, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 3, 2021

Uh oh!

afreen23 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 3, 2021

Uh oh!

openshift-ci bot commented Nov 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SanjalKatiyar commented Oct 29, 2021 •

edited

Loading

afreen23 left a comment •

edited

Loading

SanjalKatiyar Nov 2, 2021 •

edited

Loading

afreen23 left a comment •

edited

Loading