Bug 2021466: [e2e][automation] Windows guest tool mount #10402

lkladnit · 2021-11-07T17:00:39Z

Test Windows guest tool mount

Test that when Windows guest mount is unchecked at VM creation wizard, it's not attached to created custom template and VM created from it

Story: CNV-14292: add TC/automation for fixed bugs
#2 1986297 - Windows guest tool is always mounted even it's unchecked
Polarion doc
TC

openshift-ci · 2021-11-07T17:00:42Z

@lkladnit: This pull request references Bugzilla bug 1986297, which is invalid:

expected the bug to be open, but it isn't
expected the bug to target the "4.10.0" release, but it targets "4.9.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (ERRATA) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1986297: [e2e][automation] Windows guest tool mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-07T17:01:15Z

Hi @lkladnit. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lkladnit · 2021-11-08T20:02:50Z

/retest

openshift-ci · 2021-11-09T10:51:13Z

@lkladnit: This pull request references Bugzilla bug 2021466, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2021466: [e2e][automation] Windows guest tool mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lkladnit · 2021-11-09T10:52:18Z

/bugzilla refresh

openshift-ci · 2021-11-09T10:52:24Z

@lkladnit: This pull request references Bugzilla bug 2021466, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lkladnit · 2021-11-09T16:22:34Z

/retest

lkladnit · 2021-11-11T09:29:28Z

/retest

lkladnit · 2021-11-11T13:59:33Z

/test e2e-gcp-console

gouyang · 2021-11-12T09:21:38Z

there is typo in the spec file name.
looks it test with the template wizard, could we add a test check the vm wizard as well?
the tests ends up on the wizard without exiting, I think it's better to exit the wizard after the test.

lkladnit · 2021-11-14T07:49:08Z

there is typo in the spec file name.

looks it test with the template wizard, could we add a test check the vm wizard as well?

the tests ends up on the wizard without exiting, I think it's better to exit the wizard after the test.

sure

lkladnit · 2021-11-14T14:29:07Z

/retest

lkladnit · 2021-11-14T16:23:31Z

/retest

lkladnit · 2021-11-15T09:27:31Z

/retest

gouyang · 2021-11-15T11:16:42Z

It's still not exit the wizard completely. I think it's better to check VM/Template's disk tab to see the windows-guest-tool is not there, what do you think?

@lkladnit I think you can also add tests for https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=[CNV-7491](https://issues.redhat.com/browse/CNV-7491) in this PR. :)

lkladnit · 2021-11-15T19:19:12Z

It's still not exit the wizard completely. I think it's better to check VM/Template's disk tab to see the windows-guest-tool is not there, what do you think?

@lkladnit I think you can also add tests for [https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-7491](https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=%5BCNV-7491%5D(https://issues.redhat.com/browse/CNV-7491)) in this PR. :)

Don't understand. This is the TC of this PR.

lkladnit · 2021-11-15T19:21:04Z

/retest

openshift-ci · 2021-11-15T19:55:23Z

@lkladnit: This pull request references Bugzilla bug 2021466, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request.

Details

In response to this:

Bug 2021466: [e2e][automation] Windows guest tool mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-11-25T13:48:22Z

@lkladnit: This pull request references Bugzilla bug 2021466, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request.

Details

In response to this:

Bug 2021466: [e2e][automation] Windows guest tool mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lkladnit · 2021-11-25T17:00:06Z

/retest

lkladnit · 2021-11-25T17:15:59Z

/retest

lkladnit · 2021-11-25T19:55:34Z

/retest

gouyang · 2021-11-25T23:33:05Z

/retest

lkladnit · 2021-11-26T14:32:33Z

/retest

lkladnit · 2021-11-26T21:08:55Z

/retest

lkladnit · 2021-11-27T07:24:17Z

/retest

lkladnit · 2021-11-27T12:12:11Z

/retest

lkladnit · 2021-11-29T07:08:29Z

@gouyang , It passed all the tests, can it be merged?

gouyang · 2021-12-07T10:10:46Z

/lgtm

gouyang · 2021-12-07T10:11:52Z

@yaacov @pcbailey Could you review this one?

yaacov · 2021-12-07T18:14:27Z

/lgtm

openshift-ci · 2021-12-07T18:15:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, lkladnit, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lkladnit · 2021-12-08T07:15:08Z

/retest

lkladnit · 2021-12-08T14:03:05Z

/retest

lkladnit · 2021-12-08T17:05:30Z

@gouyang , @yaacov , can somebody approve it?

yaacov · 2021-12-08T18:03:50Z

/ok-to-test

@lkladnit hmm, why does it think you are not in openshift org, this is strange ?
#10402 (comment)

openshift-ci · 2021-12-08T22:03:24Z

@lkladnit: All pull requests linked via external trackers have merged:

openshift/console#10402

Bugzilla bug 2021466 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2021466: [e2e][automation] Windows guest tool mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 7, 2021

openshift-ci bot requested review from rawagner and rhrazdil November 7, 2021 17:01

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 7, 2021

lkladnit changed the title ~~Bug 1986297: [e2e][automation] Windows guest tool mount~~ Bug 2021466: [e2e][automation] Windows guest tool mount Nov 9, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 9, 2021

openshift-ci bot requested a review from gouyang November 9, 2021 10:52

lkladnit force-pushed the win_guesttool branch from e629e78 to be88685 Compare November 9, 2021 10:56

lkladnit force-pushed the win_guesttool branch 2 times, most recently from e53180a to c2f7ef0 Compare November 14, 2021 11:18

lkladnit requested a review from gouyang November 25, 2021 13:39

lkladnit force-pushed the win_guesttool branch from 7595251 to e82349a Compare November 25, 2021 13:46

Windows guest tool mount test

7829f75

lkladnit force-pushed the win_guesttool branch from e82349a to 7829f75 Compare November 26, 2021 21:11

openshift-ci bot assigned gouyang Dec 7, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2021

openshift-ci bot assigned yaacov Dec 7, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2021

openshift-merge-robot merged commit 6f01f7c into openshift:master Dec 8, 2021

Bug 2021466: [e2e][automation] Windows guest tool mount #10402

Bug 2021466: [e2e][automation] Windows guest tool mount #10402

Uh oh!

Conversation

lkladnit commented Nov 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Nov 7, 2021

Uh oh!

openshift-ci bot commented Nov 7, 2021

Uh oh!

lkladnit commented Nov 8, 2021

Uh oh!

openshift-ci bot commented Nov 9, 2021

Uh oh!

lkladnit commented Nov 9, 2021

Uh oh!

openshift-ci bot commented Nov 9, 2021

Uh oh!

lkladnit commented Nov 9, 2021

Uh oh!

lkladnit commented Nov 11, 2021

Uh oh!

lkladnit commented Nov 11, 2021

Uh oh!

gouyang commented Nov 12, 2021

Uh oh!

lkladnit commented Nov 14, 2021

Uh oh!

lkladnit commented Nov 14, 2021

Uh oh!

lkladnit commented Nov 14, 2021

Uh oh!

lkladnit commented Nov 15, 2021

Uh oh!

gouyang commented Nov 15, 2021 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lkladnit commented Nov 15, 2021

Uh oh!

lkladnit commented Nov 15, 2021

Uh oh!

openshift-ci bot commented Nov 15, 2021

Uh oh!

openshift-ci bot commented Nov 25, 2021

Uh oh!

lkladnit commented Nov 25, 2021

Uh oh!

lkladnit commented Nov 25, 2021

Uh oh!

lkladnit commented Nov 25, 2021

Uh oh!

gouyang commented Nov 25, 2021

Uh oh!

lkladnit commented Nov 26, 2021

Uh oh!

lkladnit commented Nov 26, 2021

Uh oh!

lkladnit commented Nov 27, 2021

Uh oh!

lkladnit commented Nov 27, 2021

Uh oh!

lkladnit commented Nov 29, 2021

Uh oh!

gouyang commented Dec 7, 2021

Uh oh!

gouyang commented Dec 7, 2021

Uh oh!

yaacov commented Dec 7, 2021

Uh oh!

openshift-ci bot commented Dec 7, 2021

Uh oh!

lkladnit commented Dec 8, 2021

Uh oh!

lkladnit commented Dec 8, 2021

Uh oh!

lkladnit commented Dec 8, 2021

Uh oh!

yaacov commented Dec 8, 2021

Uh oh!

lkladnit commented Nov 7, 2021 •

edited

Loading

gouyang commented Nov 15, 2021 •

edited by openshift-ci bot

Loading