Skip to content

DevConsole refactor #10420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 7, 2022
Merged

DevConsole refactor #10420

openshift-merge-robot merged 1 commit into from
Jan 7, 2022

Conversation

@ciiay
Copy link
Contributor

@ciiay ciiay commented Nov 9, 2021 •
edited
Loading

This PR resolves part of GITOPS-1276 Epic, which includes the below tickets:

  1. GITOPS-1277
  2. GITOPS-1279
  3. GITOPS-1281
  4. GITOPS-1282
  5. GITOPS-1283

@openshift-ci openshift-ci bot added the component/gitops Related to gitops-plugin label Nov 9, 2021
@wtam2018
Copy link

wtam2018 commented Nov 12, 2021

@ciiay please resolve conflict.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2021
@wtam2018
Copy link

wtam2018 commented Nov 12, 2021

@ciiay please resolve conflict.

@openshift-ci openshift-ci bot added component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 15, 2021
@ciiay ciiay force-pushed the master-gitops-refactor branch from 422889f to 10613ac Compare November 15, 2021 19:46
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/metal3 Related to metal3-plugin kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 15, 2021
@ciiay ciiay closed this Jan 5, 2022
@ciiay ciiay force-pushed the master-gitops-refactor branch from dab69c9 to 6889cf3 Compare January 5, 2022 15:24
@ciiay ciiay reopened this Jan 5, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2022
@ciiay ciiay force-pushed the master-gitops-refactor branch from e631ae5 to dab69c9 Compare January 5, 2022 15:41
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2022
@ciiay ciiay force-pushed the master-gitops-refactor branch from dab69c9 to cd9dbeb Compare January 5, 2022 16:32
@vikram-raj
Copy link
Member

vikram-raj commented Jan 5, 2022

@ciiay Frontend tests are failing. You need to update the i18n json file. Please run yarn i18n and update the PR.

@ciiay ciiay force-pushed the master-gitops-refactor branch from cd9dbeb to 4273b2e Compare January 5, 2022 17:50
vikram-raj
vikram-raj reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@ciiay
Refactor
80585ca 
Removed extra changes and added i18n changes

Picking up missed changes
@ciiay ciiay force-pushed the master-gitops-refactor branch from 4273b2e to 80585ca Compare January 5, 2022 18:13
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@ciiay ciiay requested a review from vikram-raj January 5, 2022 18:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

@ciiay: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ceph-storage-plugin e631ae5f7c131fcd9fd9a0b84bf4d1d8abfb3633 link true /test ceph-storage-plugin
ci/prow/kubevirt-plugin e631ae5f7c131fcd9fd9a0b84bf4d1d8abfb3633 link true /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vikram-raj
Copy link
Member

vikram-raj commented Jan 6, 2022

/retest

@vikram-raj
Copy link
Member

vikram-raj commented Jan 6, 2022

/lgtm

1 similar comment
@vikram-raj
Copy link
Member

vikram-raj commented Jan 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@ciiay
Copy link
Contributor Author

ciiay commented Jan 6, 2022

Adding these two labels as this is a refactor PR and no UI changes.

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 6, 2022
@varshab1210
Copy link

varshab1210 commented Jan 6, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 6, 2022
rohitkrai03
rohitkrai03 approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciiay, rohitkrai03, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 95e6876 into openshift:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@sahil143 sahil143 Awaiting requested review from sahil143

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

1 more reviewer

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vikram-raj vikram-raj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR kind/cypress Related to Cypress e2e integration testing kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ciiay @wtam2018 @keithchong @christianvogt @vikram-raj @varshab1210 @rohitkrai03 @openshift-merge-robot