Skip to content

Conversation

@sg00dwin
Copy link
Member

No description provided.

@sg00dwin sg00dwin requested a review from rhamilto January 10, 2019 19:47
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2019
@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

jenkins rebuild

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2019
@sg00dwin
Copy link
Member Author

@rhamilto Updated pr to enable vertical scroll
Follow on pr will incorporate vertical scroll shadows to modal

modal-desktop

modal-mobile

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vh units are problematic because of mobile. Did this test okay?

162px doesn't match the 177px in the comment. I assume they should?

@sg00dwin
Copy link
Member Author

jenkins rebuild

@sg00dwin sg00dwin force-pushed the modal-scroll-bug branch 3 times, most recently from b7e487d to 654ea27 Compare January 16, 2019 13:54
@sg00dwin
Copy link
Member Author

@rhamilto pr updated for review

Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @sg00dwin.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2019
@spadgett
Copy link
Member

jenkins rebuild

7 similar comments
@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

Last failure was flake https://jira.coreos.com/browse/CONSOLE-1219

@sg00dwin
Copy link
Member Author

jenkins rebuild

1 similar comment
@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

Last failure was flake https://jira.coreos.com/browse/CONSOLE-1224

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

Last failure was flake https://jira.coreos.com/browse/CONSOLE-1228

@spadgett
Copy link
Member

jenkins rebuild

4 similar comments
@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

jenkins rebuild

Remove orphaned .tags-list css and consolidate into single file
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2019
@spadgett
Copy link
Member

jenkins rebuild

1 similar comment
@spadgett
Copy link
Member

jenkins rebuild

@rhamilto
Copy link
Member

As a result of these changes, dropdowns can be masked by the footer.

screen shot 2019-01-28 at 4 48 52 pm

@sg00dwin sg00dwin deleted the modal-scroll-bug branch January 29, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants