Skip to content

Enable vertical scrolling for modal displays #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 22, 2019
Merged

Enable vertical scrolling for modal displays #1053

openshift-merge-robot merged 1 commit into from
Jan 22, 2019

Conversation

@sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jan 10, 2019

No description provided.

@sg00dwin sg00dwin requested a review from rhamilto January 10, 2019 19:47
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2019
rhamilto
rhamilto reviewed Jan 10, 2019
View reviewed changes
@spadgett
Copy link
Member

spadgett commented Jan 10, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 11, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Jan 11, 2019

jenkins rebuild

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2019
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 14, 2019

@rhamilto Updated pr to enable vertical scroll
Follow on pr will incorporate vertical scroll shadows to modal

modal-desktop

modal-mobile

rhamilto
rhamilto reviewed Jan 14, 2019
View reviewed changes
frontend/public/components/modals/_modals.scss Outdated
Copy link
Member

@rhamilto rhamilto Jan 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vh units are problematic because of mobile. Did this test okay?

162px doesn't match the 177px in the comment. I assume they should?

@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 14, 2019

jenkins rebuild

@sg00dwin sg00dwin force-pushed the modal-scroll-bug branch 3 times, most recently from b7e487d to 654ea27 Compare January 16, 2019 13:54
@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 16, 2019

@rhamilto pr updated for review

rhamilto
rhamilto approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @sg00dwin.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2019
@spadgett
Copy link
Member

spadgett commented Jan 16, 2019

jenkins rebuild

7 similar comments
@spadgett
Copy link
Member

spadgett commented Jan 16, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 17, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 17, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 17, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 17, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 17, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 18, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 18, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 18, 2019

Last failure was flake https://jira.coreos.com/browse/CONSOLE-1219

@sg00dwin
Copy link
Member Author

sg00dwin commented Jan 18, 2019

jenkins rebuild

1 similar comment
@spadgett
Copy link
Member

spadgett commented Jan 19, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 19, 2019

Last failure was flake https://jira.coreos.com/browse/CONSOLE-1224

@spadgett
Copy link
Member

spadgett commented Jan 19, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 19, 2019

Last failure was flake https://jira.coreos.com/browse/CONSOLE-1228

@spadgett
Copy link
Member

spadgett commented Jan 19, 2019

jenkins rebuild

4 similar comments
@spadgett
Copy link
Member

spadgett commented Jan 19, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 20, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 21, 2019

jenkins rebuild

@spadgett
Copy link
Member

spadgett commented Jan 21, 2019

jenkins rebuild

@sg00dwin
Make modals scrollable
8da84ba 
Remove orphaned .tags-list css and consolidate into single file
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2019
spadgett
spadgett approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2019
@spadgett
Copy link
Member

spadgett commented Jan 21, 2019

jenkins rebuild

1 similar comment
@spadgett
Copy link
Member

spadgett commented Jan 22, 2019

jenkins rebuild

@openshift-merge-robot openshift-merge-robot merged commit 67769d0 into openshift:master Jan 22, 2019
@rhamilto rhamilto mentioned this pull request Jan 28, 2019
Merged
@rhamilto
Copy link
Member

rhamilto commented Jan 28, 2019

As a result of these changes, dropdowns can be masked by the footer.

screen shot 2019-01-28 at 4 48 52 pm

@sg00dwin sg00dwin deleted the modal-scroll-bug branch January 29, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto approved these changes

@spadgett spadgett spadgett approved these changes

Assignees

@rhamilto rhamilto

@spadgett spadgett

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sg00dwin @spadgett @rhamilto @openshift-ci-robot @openshift-merge-robot