Sort catalog filters and other enhancements #11161

divyanshiGupta · 2022-03-09T08:59:59Z

Fixes: https://issues.redhat.com/browse/ODC-6491

This PR adds the fix for sorting catalog filters alphabetically and
uses useK8sWatchResource instead of k8sGet for fetching the bindable-services.

Screenshots:

/kind feature

divyanshiGupta · 2022-03-09T09:00:58Z

@beaumorley can you PTAL at this PR and approve if the badge and filters looks good to you?

divyanshiGupta · 2022-03-09T11:07:46Z

/cc @christianvogt
/cc @invincibleJai

divyanshiGupta · 2022-03-09T13:11:12Z

/retest

christianvogt · 2022-03-09T14:24:53Z

/approve

christianvogt · 2022-03-09T14:33:18Z

@beaumorley you'll see how there is a bindable as well as not bindable filter in the catalog list. This is the way the filters currently work in that all items must be covered by at least one filter. If we want to change this for boolean type filters, then we should raise a new issue with the details and not hold up this one.

christoph-jerolimov

Get this react error and then a white page when open the OperatorBackedService catalog with this PR. Can you take a look?

Error
Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
Call Stack
 checkForNestedUpdates
  vendors~main-fde4aab59bedd45747de.js:465232:15
 scheduleUpdateOnFiber
  vendors~main-fde4aab59bedd45747de.js:463264:3

/hold

christoph-jerolimov

Some more requests to add some missing types.

frontend/packages/console-shared/src/components/catalog/catalog-view/CatalogFilters.tsx

serenamarie125 · 2022-03-09T16:21:04Z

Couple comments here

I think we need to reconsider the filter "text" here. Let's cover it in the Friday call? (this shouldn't hold up merging this PR though, we can have a follow PR for text as needed)
Shouldn't there be more spacing under the Service Binding title?

Otherwise looks great! FYI @slemeur

divyanshiGupta · 2022-03-10T11:25:23Z

Get this react error and then a white page when open the OperatorBackedService catalog with this PR. Can you take a look?

Error
Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
Call Stack
 checkForNestedUpdates
  vendors~main-fde4aab59bedd45747de.js:465232:15
 scheduleUpdateOnFiber
  vendors~main-fde4aab59bedd45747de.js:463264:3

/hold

@jerolimov I couldn't reproduce this issue. Can you share the steps to reproduce this?

Screen.Recording.2022-03-10.at.4.51.35.PM.mov

divyanshiGupta · 2022-03-10T11:33:26Z

Couple comments here

I think we need to reconsider the filter "text" here. Let's cover it in the Friday call? (this shouldn't hold up merging this PR though, we can have a follow PR for text as needed)

Shouldn't there be more spacing under the Service Binding title?

Otherwise looks great! FYI @slemeur

@serenamarie125 this is how it looks like for other filters as well. We can have a separate issue for this.

divyanshiGupta · 2022-03-10T12:53:41Z

/retest

divyanshiGupta · 2022-03-10T19:20:14Z

/retest

serenamarie125

great work!

christoph-jerolimov · 2022-03-11T11:58:40Z

/retest

christoph-jerolimov · 2022-03-11T11:59:36Z

The updated flags names fix the crash when the operator is not installed.
/unhold

christoph-jerolimov · 2022-03-11T13:22:49Z

/lgtm

openshift-ci · 2022-03-11T13:23:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta, jerolimov, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt,jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-03-11T14:39:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T14:51:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T16:27:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T17:39:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T18:39:42Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T18:51:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T19:03:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T20:39:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T21:39:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T22:15:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-11T23:16:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

invincibleJai · 2022-03-14T04:23:16Z

/label docs-approved
/label px-approved

propagating above labels based on ACKs on epic

cc @rishumehra

christoph-jerolimov · 2022-03-14T09:14:09Z

Shouldn't there be more spacing under the Service Binding title?

@divyanshiGupta FYI: I created this issue and PR for the PF catalog extension.

Catalog extension: Sidebar filter title and items look a little bit squeezed patternfly/patternfly-react#7059
Catalog extension: Add a little bit spacing between title and items patternfly/patternfly-react#7060

christoph-jerolimov · 2022-03-14T09:57:31Z

Tested it on a cluster bot instance, with and without Service Binding Operator, without and with Postgres for Kubernetes operator. As kubeadmin and user with limited access.

/label qe-approved

openshift-bot · 2022-03-14T14:42:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-14T15:42:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-14T20:22:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-14T20:46:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-15T00:13:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-15T02:26:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-15T05:33:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-15T11:26:49Z

@divyanshiGupta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2022

openshift-ci bot requested review from jeff-phillips-18 and karthikjeeyar March 9, 2022 09:01

openshift-ci bot added component/dev-console Related to dev-console component/shared Related to console-shared labels Mar 9, 2022

divyanshiGupta force-pushed the sb-discoverability branch 3 times, most recently from a8f51f4 to 26cbc58 Compare March 9, 2022 11:04

openshift-ci bot requested review from christianvogt and invincibleJai March 9, 2022 11:07

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022

christoph-jerolimov suggested changes Mar 9, 2022

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022

christoph-jerolimov suggested changes Mar 9, 2022

View reviewed changes

divyanshiGupta force-pushed the sb-discoverability branch from 26cbc58 to b346736 Compare March 10, 2022 11:22

serenamarie125 reviewed Mar 10, 2022

View reviewed changes

serenamarie125 approved these changes Mar 10, 2022

View reviewed changes

divyanshiGupta force-pushed the sb-discoverability branch from b346736 to 9fc6da3 Compare March 11, 2022 09:21

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Mar 14, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 14, 2022

openshift-merge-robot merged commit 25f332c into openshift:master Mar 15, 2022

Sort catalog filters and other enhancements #11161

Sort catalog filters and other enhancements #11161

Uh oh!

Conversation

divyanshiGupta commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

divyanshiGupta commented Mar 9, 2022

Uh oh!

divyanshiGupta commented Mar 9, 2022

Uh oh!

divyanshiGupta commented Mar 9, 2022

Uh oh!

christianvogt commented Mar 9, 2022

Uh oh!

christianvogt commented Mar 9, 2022

Uh oh!

christoph-jerolimov left a comment

Choose a reason for hiding this comment

Uh oh!

christoph-jerolimov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serenamarie125 commented Mar 9, 2022

Uh oh!

divyanshiGupta commented Mar 10, 2022

Uh oh!

divyanshiGupta commented Mar 10, 2022

Uh oh!

divyanshiGupta commented Mar 10, 2022

Uh oh!

divyanshiGupta commented Mar 10, 2022

Uh oh!

serenamarie125 left a comment

Choose a reason for hiding this comment

Uh oh!

christoph-jerolimov commented Mar 11, 2022

Uh oh!

christoph-jerolimov commented Mar 11, 2022

Uh oh!

christoph-jerolimov commented Mar 11, 2022

Uh oh!

openshift-ci bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

openshift-bot commented Mar 11, 2022

Uh oh!

invincibleJai commented Mar 14, 2022

Uh oh!

christoph-jerolimov commented Mar 14, 2022

Uh oh!

christoph-jerolimov commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Mar 14, 2022

Uh oh!

openshift-bot commented Mar 14, 2022

Uh oh!

divyanshiGupta commented Mar 9, 2022 •

edited

Loading

christoph-jerolimov commented Mar 14, 2022 •

edited

Loading