Monitoring: Fix hiding sidebar links for pages the user cannot access #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
spadgett
reviewed
Jan 22, 2019
Hide the "Alerts", "Silences", "Metrics" and "Dashboards" sidebar links if the user doesn't have the necessary RBAC permissions to access those pages (GET for namespaces).
kyoto
force-pushed
the
monitoring-hide-monitoring-sidebar
branch
from
0fab7a4 to
de05374
Compare
openshift-ci-robot
added
size/M
kyoto
force-pushed
the
monitoring-hide-monitoring-sidebar
branch
from
de05374 to
075caba
Compare
Member
Author
Member
Author
|
Thanks @spadgett, I addressed your comments. |
Member
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the "Alerts" and "Silences" sidebar links if the user doesn't have
the necessary RBAC permissions to access those pages (GET for
namespaces).
Fixes https://jira.coreos.com/browse/MON-460
/cc @spadgett