Add detail and list pages for machine configs and machine config pools #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
Member
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
TheRealJon
force-pushed
the
machine-configs
branch
from
a0a4a2b to
17dbfc2
Compare
Member
|
/retest |
Member
|
Should we show the filesystems, file paths, and maybe file contents for files in the machine config? |
spadgett
reviewed
Jan 29, 2019
Member
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
Nice work on this. Just a few comments.
TheRealJon
force-pushed
the
machine-configs
branch
2 times, most recently
from
4fa6c58 to
0676f0e
Compare
spadgett
requested changes
Feb 1, 2019
Member
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
It looks like machine config and machine config pool aren't namespaced
TheRealJon
force-pushed
the
machine-configs
branch
from
0676f0e to
63fb1d6
Compare
Member
Author
|
Fixed list page content and responsiveness: Large
Medium
Small
Extra Small
|
Member
Author
|
@spadgett I have address the remaining feedback items |
spadgett
requested changes
Feb 4, 2019
spadgett
reviewed
Feb 4, 2019
TheRealJon
force-pushed
the
machine-configs
branch
from
63fb1d6 to
49811fc
Compare
Member
|
/retest |
1 similar comment
Member
|
/retest |
Member
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add detail and list pages for machine configs and machine config pools. Add new nav section to contain all Machine related items.
Machine Config Pool List
Machine Config Pool Detail
Machine Config List
Machine Config Detail
@openshift/team-ux-review