Skip to content

Conversation

@spadgett
Copy link
Member

We were unintentionally passing the event object to the modal as props.

https://jira.coreos.com/browse/CONSOLE-1240

/assign @rhamilto

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2019
We were unintentionally passing the event object to the modal as props.
@spadgett spadgett force-pushed the fix-synthetic-event-error branch from 064ec99 to f7b32a5 Compare January 28, 2019 20:00
@spadgett spadgett changed the title Fix synthentic event warnings Fix synthetic event warnings Jan 28, 2019
@spadgett
Copy link
Member Author

/retest

Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2019
@spadgett
Copy link
Member Author

/retest

3 similar comments
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit c2aff03 into openshift:master Jan 29, 2019
@spadgett spadgett deleted the fix-synthetic-event-error branch January 29, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants