Skip to content

Conversation

@dtaylor113
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2019
@dtaylor113 dtaylor113 force-pushed the create-srv-class-via-dev-catalog branch from 1fa71b0 to 98c0aa6 Compare January 30, 2019 15:47
@openshift openshift deleted a comment from openshift-ci-robot Jan 30, 2019
@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113 dtaylor113 force-pushed the create-srv-class-via-dev-catalog branch from 98c0aa6 to 1372038 Compare February 1, 2019 17:31

export const categoryTabs = $$('.vertical-tabs-pf-tab > a');
export const pageHeading = $('.co-catalog-page__heading');
export const pageNumberItemsHeading = $('.co-catalog-page__num-items');
export const pageHeadingNumberOfItems = () => pageNumberItemsHeading.getText()
.then(text => parseInt(text.substring(0, text.indexOf(' items')), 10));
export const catalogDetailsLoaded = () => browser.wait(until.presenceOf($('.modal-content')), 10000).then(() => browser.sleep(1000));
export const createServiceInstanceButton = $('.co-catalog-page__overlay-create');
export const createServiceInstanceFormIsLoaded = () => browser.wait(until.presenceOf($('.co-create-service-instance')), 10000).then(() => browser.sleep(500));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to pick up some of the fixes from #1160 to determine when the form is done loading. @TheRealJon added some utilities to make sure there are no loaders present anywhere on the page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to 'no loaders' check

@dtaylor113 dtaylor113 force-pushed the create-srv-class-via-dev-catalog branch from 1372038 to f3fb952 Compare February 4, 2019 15:43
@dtaylor113
Copy link
Contributor Author

/test console-e2e

@dtaylor113
Copy link
Contributor Author

/retest

14 similar comments
@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

@spadgett omg, this finally passed! I'm ok to merge this, but it cannot be used until we figure out how to create the Service Catalog in a v4 cluster. I have some scripts which work initially, but have issues creating the Template Service Broker reliably.

@spadgett
Copy link
Member

This is still useful for local testing even if it's not gating merge. Thanks @dtaylor113

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2019
@dtaylor113
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit c017a40 into openshift:master Mar 11, 2019
@dtaylor113 dtaylor113 deleted the create-srv-class-via-dev-catalog branch August 22, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants