-
Notifications
You must be signed in to change notification settings - Fork 667
Update service catalog tests to provision through developer catalog #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update service catalog tests to provision through developer catalog #1154
Conversation
1fa71b0 to
98c0aa6
Compare
|
/retest |
98c0aa6 to
1372038
Compare
|
|
||
| export const categoryTabs = $$('.vertical-tabs-pf-tab > a'); | ||
| export const pageHeading = $('.co-catalog-page__heading'); | ||
| export const pageNumberItemsHeading = $('.co-catalog-page__num-items'); | ||
| export const pageHeadingNumberOfItems = () => pageNumberItemsHeading.getText() | ||
| .then(text => parseInt(text.substring(0, text.indexOf(' items')), 10)); | ||
| export const catalogDetailsLoaded = () => browser.wait(until.presenceOf($('.modal-content')), 10000).then(() => browser.sleep(1000)); | ||
| export const createServiceInstanceButton = $('.co-catalog-page__overlay-create'); | ||
| export const createServiceInstanceFormIsLoaded = () => browser.wait(until.presenceOf($('.co-create-service-instance')), 10000).then(() => browser.sleep(500)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll want to pick up some of the fixes from #1160 to determine when the form is done loading. @TheRealJon added some utilities to make sure there are no loaders present anywhere on the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switched to 'no loaders' check
1372038 to
f3fb952
Compare
|
/test console-e2e |
|
/retest |
14 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@spadgett omg, this finally passed! I'm ok to merge this, but it cannot be used until we figure out how to create the Service Catalog in a v4 cluster. I have some scripts which work initially, but have issues creating the Template Service Broker reliably. |
|
This is still useful for local testing even if it's not gating merge. Thanks @dtaylor113 /lgtm |
|
/retest |
JIRA: https://jira.coreos.com/browse/CONSOLE-1208