Fix show community operator dialog styles #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Member
|
/lgtm |
spadgett
force-pushed
the
fix-community-operator-dialog-styles
branch
from
e0849fd to
df4b535
Compare
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.coreos.com/browse/CONSOLE-1250
The patternfly-react
MessageDialogisn't compatible with console modal styles, and there isn't a way to add the necessary intermediate divs using theMessageDialogcomponent to fix this bug. TheMessageDialogis also a third kind of dialog in the console and the only place we use it. We used to only have one modal.We want to switch to patternfly-react components, but we should change all of the modals at once. Having a mix of dialogs is going to lead to an inconsistent user experience, more maintenance, and bugs like this.
For now, use the same modal we use everywhere else in console.
Before:
After:
/assign @rhamilto @sg00dwin