Skip to content

Bug 1671605 - Hide Machines nav section from normal users #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 8, 2019
Merged

Bug 1671605 - Hide Machines nav section from normal users #1166

openshift-merge-robot merged 1 commit into from
Feb 8, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Feb 5, 2019

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2019
TheRealJon
TheRealJon reviewed Feb 5, 2019
View reviewed changes
frontend/public/components/nav.jsx Outdated
Copy link
Member

@TheRealJon TheRealJon Feb 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the 'required' prop for the NavSection component to take an array instead of a single flag?

@spadgett spadgett force-pushed the machine-config-permissions branch from 11b3bad to dff9211 Compare February 8, 2019 14:16
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2019
@spadgett spadgett changed the title [WIP] Bug 1671605 - Hide Machines nav section from normal users Bug 1671605 - Hide Machines nav section from normal users Feb 8, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2019
@spadgett
Copy link
Member Author

spadgett commented Feb 8, 2019

@TheRealJon thanks, updated

@spadgett spadgett force-pushed the machine-config-permissions branch from dff9211 to a72dd07 Compare February 8, 2019 14:27
TheRealJon
TheRealJon approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@spadgett
Copy link
Member Author

spadgett commented Feb 8, 2019

install failed

/retest

@openshift-merge-robot openshift-merge-robot merged commit 361814c into openshift:master Feb 8, 2019
@spadgett spadgett deleted the machine-config-permissions branch February 8, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

Assignees

@TheRealJon TheRealJon

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spadgett @TheRealJon @openshift-ci-robot @openshift-merge-robot