Skip to content

Remove "Create Machine Config" button from Machine Configs tab on MachineConfigPool detail page #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 9, 2019
Merged

Remove "Create Machine Config" button from Machine Configs tab on MachineConfigPool detail page #1167

openshift-merge-robot merged 1 commit into from
Feb 9, 2019

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Feb 5, 2019

@TheRealJon TheRealJon requested a review from spadgett February 5, 2019 20:26
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2019
spadgett
spadgett approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2019
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 6, 2019

/retest

1 similar comment
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Feb 6, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 6, 2019

/test console-e2e

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 6, 2019

/retest

9 similar comments
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 6, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 7, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

install failed

/retest

1 similar comment
@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

install failed

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

error: build error: no such image

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

4 similar comments
@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 9, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit a766235 into openshift:master Feb 9, 2019
@TheRealJon TheRealJon deleted the CONSOLE-1260 branch March 12, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TheRealJon @openshift-merge-robot @spadgett @openshift-ci-robot