Skip to content

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon requested a review from spadgett February 5, 2019 20:28
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 5, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a couple small comments

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2019
@spadgett
Copy link
Member

spadgett commented Feb 5, 2019

/test all

@openshift-merge-robot
Copy link
Contributor

/retest

1 similar comment
@openshift-merge-robot
Copy link
Contributor

/retest

@TheRealJon
Copy link
Member Author

/test console-e2e

@TheRealJon
Copy link
Member Author

/retest

9 similar comments
@TheRealJon
Copy link
Member Author

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@TheRealJon
Copy link
Member Author

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants