Skip to content

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Feb 6, 2019

Fix a bug which caused the sort functionality not to work for the status column on the Cluster Operators tab of the Cluster Settings page.

Fixes https://jira.coreos.com/browse/CONSOLE-1263

@TheRealJon TheRealJon requested a review from spadgett February 6, 2019 22:14
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for one small comment

@TheRealJon TheRealJon force-pushed the cluster-operators-sort branch from ff7d6b5 to 43e25cc Compare February 7, 2019 13:26
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/test frontend
/test backend

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

6 similar comments
@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 7, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

Annotations flake

/retest

@spadgett
Copy link
Member

spadgett commented Feb 8, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6b859f6 into openshift:master Feb 8, 2019
@TheRealJon TheRealJon deleted the cluster-operators-sort branch March 12, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants