copy ci test output files to artifacts dir on script exit #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
spadgett
reviewed
Feb 7, 2019
test-prow-e2e.sh
Outdated
| ./test-gui.sh e2e | ||
|
|
||
| cp -rv ./frontend/gui_test_screenshots "${ARTIFACT_DIR}/gui_test_screenshots" | ||
| . ./test-gui.sh e2e |
Member
There was a problem hiding this comment.
Is there a reason this needs to be . ./test-gui.sh e2e instead of just ./test-guit.sh e2e?
Member
Author
There was a problem hiding this comment.
This will run the script and not exit the entire script if the test-gui.sh sub script returns an error. The trap should handle the error case I believe....I can remove this in the test pr and check the outcome.
Member
There was a problem hiding this comment.
I'd think the trap would still work if we run it directly. Can we test?
Member
Author
There was a problem hiding this comment.
Yeah the test is running.
openshift-ci-robot
added
size/XS
Member
Author
|
/retest |
Member
Author
|
/test console-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use trap to copy test files to artifacts dir on exit of script for e2e tests