Skip to content

Conversation

@jhadvig
Copy link
Member

@jhadvig jhadvig commented Feb 12, 2019

In the latest master found an issue when the cluster-version status is not containing history field. In that case it will be destructed as undefined. So adding default value for both destructed status fields.

cluster-settings.tsx:201 Uncaught TypeError: Cannot read property 'map' of undefined
    at ClusterVersionDetailsTable (cluster-settings.tsx:201)
    at mountIndeterminateComponent (react-dom.development.js:8562)

After fixing that found another issue where the <tbody> tag can't contain <div> tag inside it, which is part of the EmptyBox component so I've restructured it:

warning.js:33 Warning: validateDOMNesting(...): <div> cannot appear as a child of <tbody>.
    in div (created by Box)
    in Box (created by EmptyBox)
    in EmptyBox (created by ClusterVersionDetailsTable)
    in tbody (created by ClusterVersionDetailsTable)
    ...

/assign @TheRealJon

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2019
@jhadvig jhadvig force-pushed the cluster-settings branch 2 times, most recently from 6738d23 to d5a5984 Compare February 12, 2019 15:12
@jhadvig
Copy link
Member Author

jhadvig commented Feb 12, 2019

/test console-e2e

@jhadvig
Copy link
Member Author

jhadvig commented Feb 12, 2019

Test Suites & Specs:

1) Basic console test
(node:3195) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
index.html not found in configured public-dir path: open frontend/public/dist/index.html: no such file or directory   ✔ logs into console if necessary
A Jasmine spec timed out. Resetting the WebDriver Control Flow.
A Jasmine spec timed out. Resetting the WebDriver Control Flow.
   ✖ creates test namespace test-cwcjp if necessary (2 failures)

@TheRealJon
Copy link
Member

/retest

@jhadvig
Copy link
Member Author

jhadvig commented Feb 13, 2019

@TheRealJon comment added and addressed. PTAL

Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2019
@openshift-merge-robot openshift-merge-robot merged commit e05b036 into openshift:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants