Skip to content

Conversation

@kyoto
Copy link
Member

@kyoto kyoto commented Feb 15, 2019

This graph was not populated with any data because it was using the
wrong metric name. node_memory_Active_bytes appears to be the correct
metric.

FYI @juzhao, @mxinden

Before

screenshot-2

After

screenshot-1

This graph was not populated with any data because it was using the
wrong metric name. `node_memory_Active_bytes` appears to be the correct
metric.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2019
@kyoto
Copy link
Member Author

kyoto commented Feb 15, 2019

/retest

2 similar comments
@kyoto
Copy link
Member Author

kyoto commented Feb 15, 2019

/retest

@kyoto
Copy link
Member Author

kyoto commented Feb 18, 2019

/retest

@juzhao
Copy link

juzhao commented Feb 18, 2019

@mxinden
The change is LGTM, WDYT?

Copy link

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2019
@spadgett
Copy link
Member

/retest

9 similar comments
@kyoto
Copy link
Member Author

kyoto commented Feb 19, 2019

/retest

@brancz
Copy link

brancz commented Feb 19, 2019

/retest

@kyoto
Copy link
Member Author

kyoto commented Feb 21, 2019

/retest

@kyoto
Copy link
Member Author

kyoto commented Feb 21, 2019

/retest

@brancz
Copy link

brancz commented Feb 21, 2019

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

Known OLM test flake

StaleElementReferenceError: stale element reference: element is not attached to the page document

/retest

@spadgett
Copy link
Member

/retest

1 similar comment
@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 30beff3 into openshift:master Feb 25, 2019
@kyoto kyoto deleted the fix-node-details-memeory-graph branch February 25, 2019 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants