Skip to content

Conversation

@sg00dwin
Copy link
Member

Requested changes for

  • Adjust .pf-c-page__sidebar nav transition-duration and transition-timing-function
  • Adjust .right-side-modal-pf transition-duration and transform origin position

- Adjust .pf-c-page__sidebar nav transition-duration and transition-timing-function
- Adjust .right-side-modal-pf transition-duration and transform origin position
@sg00dwin sg00dwin requested a review from rhamilto February 18, 2019 19:27
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 18, 2019
@rhamilto
Copy link
Member

So much better! Nice job, @sg00dwin!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2019
@sg00dwin
Copy link
Member Author

/retest

3 similar comments
@sg00dwin
Copy link
Member Author

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

Performance test flake

StaleElementReferenceError: stale element reference: element is not attached to the page document

/retest

@spadgett
Copy link
Member

olm flake

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1d84945 into openshift:master Feb 24, 2019
@sg00dwin sg00dwin deleted the transition-adjustments branch March 4, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants