Skip to content

Fix runtime exception on newly created machine config pools #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 25, 2019
Merged

Fix runtime exception on newly created machine config pools #1203

openshift-merge-robot merged 1 commit into from
Feb 25, 2019

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Feb 20, 2019 •
edited
Loading

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1678556

Runtime error was caused by undefined status stanza for newly created MachineConfigPools. Null checks and default values are now in place.

@TheRealJon TheRealJon requested a review from spadgett February 20, 2019 15:37
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2019
spadgett
spadgett approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
@spadgett
Copy link
Member

spadgett commented Feb 22, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 22, 2019

/retest

level=error msg="Error: Error applying plan:"
level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.vpc.aws_route.igw_route: 1 error occurred:"
level=error msg="\t* aws_route.igw_route: Error creating route: timeout while waiting for state to become 'success' (timeout: 2m0s)"

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 22, 2019

/retest

error: could not run steps: test "release-latest" failed: the pod ci-op-fbbn1qpw/release-latest failed after 1m26s (failed containers: release): ContainerFailed one or more containers exited

@spadgett
Copy link
Member

spadgett commented Feb 22, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
@spadgett
Copy link
Member

spadgett commented Feb 22, 2019

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
@spadgett
Copy link
Member

spadgett commented Feb 23, 2019

/retest

1 similar comment
@spadgett
Copy link
Member

spadgett commented Feb 24, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 24, 2019

deploy image flake

/retest

@spadgett
Copy link
Member

spadgett commented Feb 24, 2019

overview test flake

/retest

@spadgett
Copy link
Member

spadgett commented Feb 24, 2019

/retest

3 similar comments
@spadgett
Copy link
Member

spadgett commented Feb 24, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 25, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Feb 25, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 38ff708 into openshift:master Feb 25, 2019
@TheRealJon TheRealJon deleted the bug-1678556 branch March 12, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TheRealJon @spadgett @openshift-ci-robot @openshift-merge-robot