Skip to content

Conversation

@spadgett
Copy link
Member

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1677545

We weren't calling bulkAddToList on the last chunk of data since response.metadata.continue wasn't defined.

@alecmerdler Let me know if this looks right. I'd your input on how to change k8s-actions-spec.ts to check this.

/cc @alecmerdler @rhamilto

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2019
@spadgett
Copy link
Member Author

/retest

1 similar comment
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

lgtm, tagging since all but 3 lines of this code are from @alecmerdler :)

(see second commit)

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@spadgett
Copy link
Member Author

/retest

1 similar comment
@spadgett
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3910e5c into openshift:master Feb 24, 2019
@spadgett spadgett deleted the incremental-load branch February 24, 2019 17:43
@spadgett
Copy link
Member Author

/cherrypick release-3.11

@openshift-cherrypick-robot

@spadgett: #1204 failed to apply on top of branch "release-3.11":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/public/module/k8s/k8s-actions.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/module/k8s/k8s-actions.ts
CONFLICT (content): Merge conflict in frontend/public/module/k8s/k8s-actions.ts
Patch failed at 0001 Bug 1677545 - Correctly handle last chunk on incremental load

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants