Skip to content

Fix merge queue #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spadgett wants to merge 2 commits into from
Closed

Fix merge queue #1207

spadgett wants to merge 2 commits into from

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Feb 21, 2019

Combines approved PRs #1197 and #1206 in order to unblock the merge queue.

@spadgett
Test in-cluster console for e2e tests
b9b5614 
Previously we were running the bridge binary locally. Instead test the
in-cluster console, which tests the built console image.
@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 21, 2019
@spadgett
Bug 1679272 - Validate console can talk to OAuth token URL
159179c 
Make sure we can successfully talk to the OAuth token URL after
discovering metadata before marking the console pod as ready.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1679272
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2019

New changes are detected. LGTM label has been removed.

@spadgett spadgett added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@spadgett spadgett mentioned this pull request Feb 21, 2019
Merged
@spadgett
Copy link
Member Author

spadgett commented Feb 21, 2019

/close

We got lucky and #1206 merged on its own.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2019

@spadgett: Closed this PR.

Details

In response to this:

/close

We got lucky and #1206 merged on its own.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2019

@spadgett: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 159179c link /test images
ci/prow/console-e2e 159179c link /test console-e2e
ci/prow/frontend 159179c link /test frontend
ci/prow/backend 159179c link /test backend

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett deleted the fix-merge-queue branch May 1, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spadgett @openshift-ci-robot