Skip to content

Conversation

@rebeccaalpert
Copy link
Contributor

The 4.0 docs are being restructured, so I removed the links we generate based on the base URL. We can add them back in once the docs are finalized.

Fixes CONSOLE-1244.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2019
The 4.0 docs are being restructured currently, so I removed the links we generate. We can add them back in once the docs are finalized.

Fixes https://jira.coreos.com/projects/CONSOLE/issues/CONSOLE-1244
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2019
@spadgett
Copy link
Member

/test

@spadgett
Copy link
Member

/refresh

@spadgett
Copy link
Member

spadgett commented Feb 22, 2019

/hold
/close

@openshift-ci-robot
Copy link
Contributor

@spadgett: Closed this PR.

Details

In response to this:

/hold
/close
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
@spadgett
Copy link
Member

/reopen

@openshift-ci-robot
Copy link
Contributor

@spadgett: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2019
@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
@spadgett
Copy link
Member

/retest

6 similar comments
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 36d7139 into openshift:master Feb 25, 2019
@rebeccaalpert rebeccaalpert deleted the documentation-updates branch February 25, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants