Skip to content

Add default catalog item icon #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 15, 2019
Merged

Add default catalog item icon #1213

openshift-merge-robot merged 1 commit into from
Mar 15, 2019

Conversation

@nicolethoen
Copy link
Member

@nicolethoen nicolethoen commented Feb 22, 2019 •
edited
Loading

Fixes CONSOLE 1194

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2019
@nicolethoen nicolethoen requested review from rhamilto and removed request for dtaylor113 February 22, 2019 15:58
dtaylor113
dtaylor113 reviewed Feb 22, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2019
rhamilto
rhamilto reviewed Feb 25, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2019
@nicolethoen
Copy link
Member Author

nicolethoen commented Feb 26, 2019

/retest

1 similar comment
@nicolethoen
Copy link
Member Author

nicolethoen commented Feb 28, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 1, 2019

@nicolethoen It seems like these are two separate fixes. Can you make separate PRs?

How does this relate to #1198?

spadgett
spadgett requested changes Mar 1, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2019
@nicolethoen nicolethoen force-pushed the default_catalog_icon branch from 3b28c84 to 342a7a0 Compare March 4, 2019 15:32
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2019
@nicolethoen nicolethoen force-pushed the default_catalog_icon branch from 342a7a0 to 92690c7 Compare March 7, 2019 20:24
@nicolethoen
Copy link
Member Author

nicolethoen commented Mar 7, 2019 •
edited
Loading

@nicolethoen It seems like these are two separate fixes. Can you make separate PRs?

@spadgett I broke it into two PRs

How does this relate to #1198?

I will double check.

@nicolethoen
Copy link
Member Author

nicolethoen commented Mar 7, 2019

/retest

@nicolethoen nicolethoen changed the title Add default catalog item icon and fix resource dropdown height Add default catalog item icon Mar 8, 2019
@nicolethoen nicolethoen force-pushed the default_catalog_icon branch from 92690c7 to b057d72 Compare March 8, 2019 16:36
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2019
@nicolethoen
Copy link
Member Author

nicolethoen commented Mar 8, 2019

@spadgett

How does this relate to #1198?

According to Serena, the operator hub should be using a different default icon from source-2-image, service classes and operator resources. So I removed the change I made to the operator hub. They shouldn't conflict anymore

@serenamarie125
Copy link
Contributor

serenamarie125 commented Mar 8, 2019

@spadgett i had two JIRA bugs - one for the Operator Hub, and the other for the Developer Catalog.

@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

Thanks @nicolethoen

/assign @rhamilto

@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

/retest

3 similar comments
@nicolethoen
Copy link
Member Author

nicolethoen commented Mar 11, 2019

/retest

@nicolethoen
Copy link
Member Author

nicolethoen commented Mar 14, 2019

/retest

@nicolethoen
Copy link
Member Author

nicolethoen commented Mar 14, 2019

/retest

@nicolethoen nicolethoen force-pushed the default_catalog_icon branch from b057d72 to 57b017b Compare March 14, 2019 14:40
@rhamilto
Copy link
Member

rhamilto commented Mar 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nicolethoen, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@spadgett
Copy link
Member

spadgett commented Mar 14, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 14, 2019 

level=info msg="Creating cluster..."
level=error
level=error msg="Error: Error applying plan:"
level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.bootstrap.aws_instance.bootstrap: 1 error occurred:"
level=error msg="\t* aws_instance.bootstrap: Error waiting for instance (i-0280f149fc3555786) to become ready: Failed to reach target state. Reason: Server.InternalError: Internal error on launch"

/test e2e-aws-console

@spadgett
Copy link
Member

spadgett commented Mar 14, 2019

/retest

4 similar comments
@spadgett
Copy link
Member

spadgett commented Mar 14, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 15, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 15, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 15, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 15, 2019 •
edited
Loading

@nicolethoen: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/console-e2e b057d72c2d02fe4644783348ebdaaf7f0aabd53d link /test console-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 344ac5b into openshift:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto left review comments

@spadgett spadgett spadgett requested changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nicolethoen @spadgett @serenamarie125 @rhamilto @openshift-ci-robot @openshift-bot @dtaylor113 @openshift-merge-robot