Skip to content

Conversation

@sg00dwin
Copy link
Member

Which tightens up the container table rows for better presentation.

https://jira.coreos.com/browse/CONSOLE-1290

@sg00dwin sg00dwin requested a review from spadgett February 22, 2019 16:56
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@spadgett
Copy link
Member

/retest

2 similar comments
@spadgett
Copy link
Member

/retest

@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit af377b4 into openshift:master Feb 25, 2019
@sg00dwin sg00dwin deleted the container-image-truncate branch February 26, 2019 19:35
@yapei
Copy link
Contributor

yapei commented Mar 8, 2019

@sg00dwin do you know why did we also remove the fast copy(I remember it's a sign of +) from container table? Truncate the image names sounds no problem, but it's better if we can provide a copy from there.

@sg00dwin
Copy link
Member Author

@yapei A PR was merged that better communicates that the image truncated string can be selected and copied. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants