Skip to content

[Do Not Merge] Remove await from overview test assertions #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheRealJon wants to merge 1 commit into from
Closed

[Do Not Merge] Remove await from overview test assertions #1224

TheRealJon wants to merge 1 commit into from

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Feb 25, 2019

Troubleshoot test flakes that cannot be reproduced locally. Hoping to reproduce overview test flake and get a little more insight from stack traces/screenshots when await is removed from the assertions.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2019
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 25, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2019
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 25, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2019 •
edited
Loading

@TheRealJon: The following test failed for commit 4948306, say /retest to rerun them:

Test name Details Rerun command
ci/prow/console-e2e link /test console-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 26, 2019

/retest

6 similar comments
@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 26, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 26, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 26, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 27, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 27, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Feb 27, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

This was part of #1236

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 8, 2019

@spadgett: Closed this PR.

Details

In response to this:

This was part of #1236

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon TheRealJon deleted the CONSOLE-1298 branch June 26, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheRealJon @openshift-ci-robot @spadgett