auth: use proxy from environment when connecting to OAuth server

[patlachance]

Fixes #1248

https://jira.coreos.com/browse/CONSOLE-1440

[openshift-ci-robot]

Hi @patlachance. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

Hi @patlachance. How does the environment variable get set? Is this a manual edit to the deployment?

Note that in 4.0 we have an operator that would overwrite changes to env vars.

cc @enj

[jhadvig]

@patlachance could you please rebase this PR, so we can merge it ?

[spadgett]

Hi, @patlachance. I rebased your PR for you. Hope you don't mind. Thanks for your contribution.

Now that openshift/console-operator#254 is complete, we should be able to go ahead with this change.

[spadgett]

/approve
/lgtm
/ok-to-test

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patlachance, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/auth/OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

/retest

[spadgett]

/retest

[openshift-ci-robot]

@patlachance: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	bfd528b	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.