Skip to content

Bug 1685006: Show mock resource quota page when user has no projects #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 7, 2019
Merged

Bug 1685006: Show mock resource quota page when user has no projects #1250

openshift-merge-robot merged 1 commit into from
Mar 7, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Mar 4, 2019

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2019
@spadgett
Copy link
Member Author

spadgett commented Mar 4, 2019

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2019
jhadvig
jhadvig approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected. Thanks @spadgett 👍
/lgtm

@jhadvig
Copy link
Member

jhadvig commented Mar 4, 2019

/retest

@jhadvig
Copy link
Member

jhadvig commented Mar 5, 2019

installer error
/retest

@jhadvig
Copy link
Member

jhadvig commented Mar 5, 2019 

Error: Failed expectation
    at Object.<anonymous> (/go/src/github.com/openshift/console/frontend/integration-tests/tests/operator-hub/operator-hub.scenario.ts:131:72)
    at step (/go/src/github.com/openshift/console/frontend/integration-tests/tests/operator-hub/operator-hub.scenario.ts:33:23)
    at Object.next (/go/src/github.com/openshift/console/frontend/integration-tests/tests/operator-hub/operator-hub.scenario.ts:14:53)
    at fulfilled (/go/src/github.com/openshift/console/frontend/integration-tests/tests/operator-hub/operator-hub.scenario.ts:5:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

/retest

@jhadvig
Copy link
Member

jhadvig commented Mar 5, 2019 

end/integration-tests/tests/modal-annotations.scenario.ts:32:23
       at Object.next /go/src/github.com/openshift/console/frontend/integration-tests/tests/modal-annotations.scenario.ts:13:53
       at fulfilled /go/src/github.com/openshift/console/frontend/integration-tests/tests/modal-annotations.scenario.ts:4:58
       at process._tickCallback internal/process/next_tick.js:68:7

/retest

@spadgett
Copy link
Member Author

spadgett commented Mar 7, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit ad3b3f0 into openshift:master Mar 7, 2019
@spadgett spadgett deleted the quota-page-mock branch March 7, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

Assignees

@jhadvig jhadvig

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spadgett @jhadvig @openshift-ci-robot @openshift-merge-robot