Updates to Machine, MachineSets #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
Member
sg00dwin
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
spadgett
requested changes
Mar 11, 2019
frontend/public/components/nav.jsx
Outdated
| @@ -374,7 +374,8 @@ export const Navigation = ({ isNavOpen, onNavSelect }) => { | |||
|
|
|||
| <MonitoringNavSection /> | |||
|
|
|||
| <NavSection title="Machines" required={[FLAGS.CLUSTER_API, FLAGS.MACHINE_CONFIG, FLAGS.CAN_LIST_MACHINE_CONFIG]}> | |||
| <NavSection title="Compute" required={[FLAGS.CLUSTER_API, FLAGS.MACHINE_CONFIG, FLAGS.CAN_LIST_MACHINE_CONFIG]}> | |||
Member
There was a problem hiding this comment.
We'll need to update the required logic here. This will hide the entire nav section if the machine API is not there, but we would still want to show nodes in that case.
Member
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
|
@sg00dwin you need to update the performance test for node to use the new nav section |
Member
- Rename machines sidnav item to "Compute" - Move Nodes into the sidenav Compute section - Add machines column into Nodes list view - Remove orphaned code - Add horizontal separator between Machine Config and Machine Config pools Console story - https://jira.coreos.com/browse/CONSOLE-1284
openshift-ci-robot
added
size/L
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sg00dwin, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
Author
|
/retest |
Member
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console story - https://jira.coreos.com/browse/CONSOLE-1284
@beanh66
