Skip to content

Bug 1685661: Reload OAuth config at every point of use #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 13, 2019
Merged

Bug 1685661: Reload OAuth config at every point of use #1271

openshift-merge-robot merged 1 commit into from
Mar 13, 2019

Conversation

@enj
Copy link
Contributor

@enj enj commented Mar 8, 2019

This change makes the console backend refresh the OAuth config on every use. This guarantees that the console never has any stale metadata in use. When combined with the changes in [1], the console backend now correctly reloads all state related to login flows.

[1] 42139fd

Bug 1685661

Signed-off-by: Monis Khan mkhan@redhat.com

/assign @spadgett @benjaminapetersen

@enj
Reload OAuth config at every point of use
d35a209 
This change makes the console backend refresh the OAuth config on
every use.  This guarantees that the console never has any stale
metadata in use.  When combined with the changes in [1], the console
backend now correctly reloads all state related to login flows.

[1] 42139fd

Bug 1685661

Signed-off-by: Monis Khan <mkhan@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 8, 2019
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Mar 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2019
@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

/retest

23 similar comments
@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 8, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 9, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Mar 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 9, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 10, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Mar 10, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Mar 11, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Mar 11, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Mar 11, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Mar 11, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/retest

14 similar comments
@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 11, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 12, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 12, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 12, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 12, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 12, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 12, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 12, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 13, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Mar 13, 2019

/retest

@enj
Copy link
Contributor Author

enj commented Mar 13, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 13, 2019

/approve
/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, enj, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@spadgett
Copy link
Member

spadgett commented Mar 13, 2019 •
edited
Loading

Opened flake https://jira.coreos.com/browse/CONSOLE-1327 to track the previous failure

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 290ccf1 into openshift:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@benjaminapetersen benjaminapetersen

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@enj @benjaminapetersen @spadgett @openshift-ci-robot @openshift-bot @openshift-merge-robot