Skip to content

Conversation

@spadgett
Copy link
Member

Here is a first pass at adding some OWNERS files. I'm open to changing who is listed here. Just trying to get something set up.

Note that "reviewers" only controls who the bot suggests as a reviewer. Anyone in the OpenShift org can /lgtm a PR if an approver has approved.

https://jira.coreos.com/browse/CONSOLE-1315

/assign @rhamilto @benjaminapetersen @alecmerdler
@pweil- @bparees fyi

/hold
for feedback

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2019
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2019
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2a06682 into openshift:master Mar 12, 2019
@spadgett spadgett deleted the owners branch March 12, 2019 20:02
@spadgett
Copy link
Member Author

/cherrypick release-3.11

@openshift-cherrypick-robot

@spadgett: #1277 failed to apply on top of branch "release-3.11":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	frontend/public/components/operator-lifecycle-manager/OWNERS
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): frontend/public/components/operator-lifecycle-manager/OWNERS deleted in HEAD and modified in Add OWNERS files. Version Add OWNERS files of frontend/public/components/operator-lifecycle-manager/OWNERS left in tree.
Patch failed at 0001 Add OWNERS files

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants