Skip to content

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Mar 22, 2019

Option to replace #1284

Differs from #1284

  • reduces padding in notifications so they consume less vertical space
  • positioning of notifications (top, bottom, topBottom)
  • option to set notification background color
  • option to set notification text color
  • link
    • href must now be an absolute url
    • option to open link in new window with new window indicator icon

localhost_9000_k8s_cluster_console openshift io_v1_ConsoleNotification_example_yaml

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2019
@rhamilto rhamilto changed the title [WIP] Add ConsoleNotification CRD that can appear above or bedlow the page [WIP] Add ConsoleNotification CRD that can appear above or below the page Mar 22, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 22, 2019
@openshift-ci-robot
Copy link
Contributor

@rhamilto: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console f95e9e6 link /test e2e-aws-console
ci/prow/e2e-aws f95e9e6 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhamilto
Copy link
Member Author

Closing in favor of #1325

@rhamilto rhamilto closed this Mar 29, 2019
@rhamilto rhamilto deleted the console-notification-crd-top-bottom branch April 8, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants