Skip to content

Move overview group and filter state to redux #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 2, 2019
Merged

Move overview group and filter state to redux #1336

openshift-merge-robot merged 1 commit into from
Apr 2, 2019

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Mar 25, 2019 •
edited
Loading

Fixes #1296

Moved state related to overview grouping and filtering into redux.

@TheRealJon TheRealJon requested a review from spadgett March 25, 2019 16:55
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2019
@TheRealJon TheRealJon force-pushed the issue-1296 branch 2 times, most recently from 25efcc5 to 493b2e7 Compare March 25, 2019 16:58
@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 25, 2019

/retest

spadgett
spadgett reviewed Mar 25, 2019
View reviewed changes
@TheRealJon TheRealJon force-pushed the issue-1296 branch 2 times, most recently from a73f3a1 to 5539b85 Compare March 27, 2019 15:44
@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 27, 2019

/retest

1 similar comment
@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 27, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Mar 27, 2019

If I type into the filter, leave the page, then come back, the filter is active, but no value shows up in the filter input.

@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 27, 2019

Hmm, oh you know, I should probably wire the redux value to the input element value attribute ... 🤦‍♂️

@spadgett
Copy link
Member

spadgett commented Mar 27, 2019

Yeah, I wonder also if we should preserve the filter value across page navigation. I guess it's useful when hitting the back button. It might be weird if you've switched to a different project, but the filter from the last project you viewed is still active.

@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 27, 2019

True, I can just clear it on unmount.

@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 27, 2019

@spadgett updated the overview header to reset the redux filter value when it unmounts.

@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 28, 2019

/retest

@TheRealJon
Copy link
Member Author

TheRealJon commented Mar 29, 2019

/retest

spadgett
spadgett reviewed Apr 1, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the comment to componentWillUnmount explaining. Otherwise I'm worried someone will think it's unnecessary and remove it later as "code clean up."

@TheRealJon
Copy link
Member Author

TheRealJon commented Apr 1, 2019

@spadgett I've addressed you last comment

@TheRealJon
Copy link
Member Author

TheRealJon commented Apr 2, 2019

/retest

spadgett
spadgett approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2019
@spadgett
Copy link
Member

spadgett commented Apr 2, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 8ca5146 into openshift:master Apr 2, 2019
@TheRealJon TheRealJon deleted the issue-1296 branch April 2, 2019 13:52
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 2, 2019

@TheRealJon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm b057484 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@rhamilto rhamilto Awaiting requested review from rhamilto

+1 more reviewer

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TheRealJon @spadgett @openshift-ci-robot @dtaylor113 @openshift-merge-robot