Add ConsoleLink CRD to enable custom links in help and user dropdowns

[rhamilto]

https://jira.coreos.com/browse/CONSOLE-1483

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: consolelinks.console.openshift.io
  annotations:
    displayName: ConsoleLinks
    description: Extension for customizing OpenShift web console links
spec:
  scope: Cluster
  group: console.openshift.io
  versions:
  - name: v1
    served: true
    storage: true
  names:
    plural: consolelinks
    singular: consolelink
    kind: ConsoleLink
    listKind: ConsoleLinkList
  additionalPrinterColumns:
  - name: Text
    type: string
    JSONPath: .spec.text
  - name: URL
    type: string
    JSONPath: .spec.href
  - name: Menu
    type: string
    JSONPath: .spec.menu
  - name: Age
    type: date
    JSONPath: .metadata.creationTimestamp
  subresources:
    status: {}
  validation:
    openAPIV3Schema:
      properties:
        spec:
          type: object
          description: Represents console link customizations spec
          required:
          - text
          - href
          - location
          properties:
            text:
              type: string
              description: Text of the link
            href:
              type: string
              description: Absolute secure URL for the link (must use https)
              pattern: '^https://([\w-]+.)+[\w-]+(/[\w- ./?%&=])?$'
            location:
              type: string
              description: Determines which dropdown menu the link is added to (HelpMenu, UserMenu)
              pattern: ^(HelpMenu|UserMenu)$

[benjaminapetersen]

The CRD file can be removed from this PR. frontend/extensions/console-link.crd.yaml

[rhamilto]

/retest

[christianvogt]

@spadgett we should create extensions for all these areas of contribution and then have the CRD simply populate the extensions
FYI @vojtechszocs

[rhamilto]

/retest

[spadgett]

@spadgett we should create extensions for all these areas of contribution and then have the CRD simply populate the extensions
FYI @vojtechszocs

Makes sense, I agree.

If you don't mind, I suggest we get the initial change in and then make it a proper extension in a follow-on so we don't miss 4.2. This PR has been blocked for about 3 months on API changes and was originally written before static plugins were added!

[spadgett]

/lgtm

@rhamilto Please open a follow on issue to add an extension point for static plugins to contribute links. Some examples are #1668 and #1615. Thanks!

[spadgett]

nit: We probably want title case in the YAML template since the other menu items are title case

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[spadgett]

@spadgett we should create extensions for all these areas of contribution and then have the CRD simply populate the extensions
FYI @vojtechszocs

@christianvogt I opened an issue to make this change: https://jira.coreos.com/browse/CONSOLE-1571