Skip to content

Bug 1694542 - Hide View CSV action when no installed CSV #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 3, 2019
Merged

Bug 1694542 - Hide View CSV action when no installed CSV #1370

openshift-merge-robot merged 1 commit into from
Apr 3, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 2, 2019

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2019
@rhamilto
Copy link
Member

rhamilto commented Apr 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@spadgett spadgett added this to the v4.1 milestone Apr 2, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

/retest

alecmerdler
alecmerdler approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

frontend/public/components/operator-lifecycle-manager/subscription.tsx
return {
label: `View ${ClusterServiceVersionModel.kind}...`,
href: `/k8s/ns/${obj.metadata.namespace}/${ClusterServiceVersionModel.plural}/${installedCSV}`,
hidden: !installedCSV,
Copy link
Contributor

@alecmerdler alecmerdler Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't realize we had a hidden argument for kebab actions.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

Ran the Operator Hub tests locally without failure. They're currently broken in CI :(

Summary:

Suites:  6 of 6
Specs:   51 of 53 (2 pending)
Expects: 63 (0 failures)
Finished in 135.376 seconds

/skip

@spadgett
Copy link
Member Author

spadgett commented Apr 2, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 3, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2019 •
edited
Loading

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 6742fae link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member Author

spadgett commented Apr 3, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit eb2ac84 into openshift:master Apr 3, 2019
@spadgett spadgett deleted the view-csv-hidden branch April 3, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@alecmerdler alecmerdler alecmerdler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rhamilto rhamilto

@alecmerdler alecmerdler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@spadgett @rhamilto @openshift-ci-robot @openshift-bot @alecmerdler @openshift-merge-robot