Skip to content

Remove placeholder style from Events dropdown filter #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 6, 2019
Merged

Remove placeholder style from Events dropdown filter #1378

openshift-merge-robot merged 1 commit into from
Apr 6, 2019

Conversation

@rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Apr 3, 2019

Added selectedKey prop to the dropdown.

The dropdown filter on the right no longer uses the placeholder style:
Screen Shot 2019-04-03 at 1 58 31 PM

Fixes CONSOLE-1347.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2019
spadgett
spadgett approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2019
@spadgett
Copy link
Member

spadgett commented Apr 3, 2019

OLM tests are broken in CI right now

/skip

@spadgett
Copy link
Member

spadgett commented Apr 3, 2019

/test e2e-aws-console

4 similar comments
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 3, 2019

/test e2e-aws-console

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 3, 2019

/test e2e-aws-console

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 3, 2019

/test e2e-aws-console

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 3, 2019

/test e2e-aws-console

@jhadvig
Copy link
Member

jhadvig commented Apr 4, 2019 

could not wait for build: the build console failed with reason DockerBuildFailed: Docker build strategy has failed.

[94] ./node_modules/cache-loader/dist/cjs.js!./node_mo...ader.js??ref--6-5!./public/vendor.scss 1.07 MiB {0} [built]
        + 94 hidden modules
Done in 157.96s.
/go/src/github.com/openshift/console
error: build error: no such image

/retest

@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Apr 4, 2019

/test e2e-aws-console

dtaylor113
dtaylor113 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Apr 4, 2019

/test e2e-aws-console

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019 •
edited
Loading

@rebeccaalpert: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 0523f54 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 5, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.1 milestone Apr 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit a3f8d61 into openshift:master Apr 6, 2019
@rebeccaalpert rebeccaalpert deleted the event-dropdown branch April 8, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

+1 more reviewer

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

7 participants

@rebeccaalpert @spadgett @jhadvig @openshift-ci-robot @openshift-bot @dtaylor113 @openshift-merge-robot