Skip to content

Add missing <noscript>, remove product name from tokener.html #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 6, 2019
Merged

Add missing <noscript>, remove product name from tokener.html #1390

openshift-merge-robot merged 1 commit into from
Apr 6, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 5, 2019 •
edited
Loading

If JavaScript is not enabled, a blank white page is seen in the browser. Adding the missing <noscript> puts a message on the page indicating JavaScript is required.

@rhamilto
Add missing <noscript>, remove product name from tokener.html
9828dd8 
If JavaScript is not enabled, a blank white page is seen in the browser.  Adding the missing <noscript> puts a message on the page indicating JavaScript is required.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2019
spadgett
spadgett approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.1 milestone Apr 5, 2019
@spadgett
Copy link
Member

spadgett commented Apr 5, 2019

/retest

@rhamilto
Copy link
Member Author

rhamilto commented Apr 5, 2019

/test e2e-aws-console-olm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 5, 2019

@rhamilto: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 9828dd8 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member

spadgett commented Apr 5, 2019

/skip

@openshift-merge-robot openshift-merge-robot merged commit 9fc1af9 into openshift:master Apr 6, 2019
@rhamilto rhamilto deleted the noscript branch April 8, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamilto @openshift-ci-robot @spadgett @openshift-merge-robot