Skip to content

Correctly specify OpenID CA #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 6, 2019
Merged

Correctly specify OpenID CA #1392

openshift-merge-robot merged 1 commit into from
Apr 6, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 6, 2019

I was adding some TypeScript types for identity providers in master-next and caught this problem. The ca property should be inside the openID config.

/assign @jcaianirh

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 6, 2019 •
edited
Loading

@spadgett: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 8927b64 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member Author

spadgett commented Apr 6, 2019

/skip

jcaianirh
jcaianirh approved these changes Apr 6, 2019
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good catch @spadgett

@jcaianirh
Copy link
Member

jcaianirh commented Apr 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dca6af2 into openshift:master Apr 6, 2019
@spadgett spadgett deleted the fix-openid-ca branch April 6, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaianirh jcaianirh jcaianirh approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

Assignees

@jcaianirh jcaianirh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spadgett @openshift-ci-robot @jcaianirh @openshift-merge-robot