Add console-scripts package

[vojtechszocs]

This PR adds new console-scripts package containing common scripts available to all packages.

This is conceptually similar to fabric8-ui scripts package. Reusing scripts across packages allows for aligning common workflows such as testing, linting, etc. and therefore improve monorepo cohesiveness.

"scripts": {
-  "test": "yarn --cwd ../.. run test packages/console-shared"
+  "test": "console-test"
}

Here's what happens when you run the console-test script:

• check if the script was called from within the Console monorepo
• execute yarn test packages/<caller-pkg> in the monorepo root directory

Note: Jest testRegex option was modified to allow future test co-location.

I've tested this by adding a temporary packages/console-shared/src/index.test.js file and running yarn test in the monorepo root and then in the packages/console-shared directory. Both global and package-specific test workflow works as expected.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vojtechszocs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bparees

If they are not already assigned, you can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vojtechszocs]

/cc @spadgett @jhadvig @christianvogt @priley86 @mareklibra @rawagner @jelkosz

[openshift-ci-robot]

@vojtechszocs: GitHub didn't allow me to request PR reviews from the following users: mareklibra, rawagner, jelkosz.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @spadgett @jhadvig @christianvogt @priley86 @mareklibra @rawagner @jelkosz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vojtechszocs]

vojtechszocs wants to merge 20 commits

Edit: forgot to switch to master-next branch 🤦‍♂️ 😆

[vojtechszocs]

Normally I'd create named ESLint configs, e.g. .eslintrc.node and .eslintrc.browser, but wanted to minimize my changes so just reusing an existing one for now.

[vojtechszocs]

/retest

[christianvogt]

@vojtechszocs often we add an argument to run a specific test, or extra jest options. Looks like this will not work with this approach when running the console-test within a package. What should a dev do in this case?

[vojtechszocs]

@vojtechszocs often we add an argument to run a specific test, or extra jest options. Looks like this will not work with this approach when running the console-test within a package. What should a dev do in this case?

That's a good point, I missed that 😐

I'll update the console-test script to pass additional command line arguments (process.argv.slice(2)) to the yarn test execution.

[christianvogt]

I don't think you can simply pass all the args because you're also adding the dir as an arg to run tests for the package. If the user wants to run tests for a specific file, they can't do so as all tests in the package will still be picked up.

[openshift-ci-robot]

@vojtechszocs: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vojtechszocs]

/hold

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-ci-robot]

@vojtechszocs: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	3797390	link	/test e2e-aws
ci/prow/e2e-aws-console-olm	3797390	link	/test e2e-aws-console-olm
ci/prow/e2e-aws-console	3797390	link	/test e2e-aws-console
ci/prow/images	3797390	link	/test images
ci/prow/frontend	3797390	link	/test frontend
ci/prow/e2e-gcp	3797390	link	/test e2e-gcp
ci/prow/e2e-gcp-console	3797390	link	/test e2e-gcp-console
ci/prow/analyze	3797390	link	/test analyze
ci/prow/kubevirt-plugin	3797390	link	/test kubevirt-plugin

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.