CONSOLE-4492: Align spacing of page elements with PatternFly #14805

rhamilto · 2025-02-27T14:30:08Z

Replace co-m-page__body with PatternFly's Flex component
Use PatternFly's PageBreadcrumb to position breadcrumbs
Replace div#app-content with PatternFly's Flex component
Replace co-m-pane__body and co-m-nav-title with PatternFly's PageSection component

openshift-ci-robot · 2025-02-27T14:30:12Z

@rhamilto: This pull request references CONSOLE-4492 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-02-27T14:35:50Z

@rhamilto: This pull request references CONSOLE-4492 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Replace co-m-page__body with PatternFly's Flex component

Use PatternFly's PageBreadcrumb to position breadcrumbs

Replace div#app-content with PatternFly's Flex component

Replace co-m-pane__body and co-m-nav-title with PatternFly's PageSection component

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto · 2025-02-27T14:57:15Z

frontend/public/components/search.tsx

Remove divider so the page layout is consistent with other pages in Home.

rhamilto · 2025-02-27T14:58:27Z

frontend/public/components/events.jsx

Removing detail={true} removes the divider between the header and the page contents so the layout is consistent with other pages in Home.

rhamilto · 2025-02-27T14:59:02Z

frontend/public/style/ancillary/_bootstrap-residual.scss

Not needed.

rhamilto · 2025-02-27T14:59:26Z

frontend/public/style/_vars.scss

Align values with PatternFly 6.

rhamilto · 2025-02-27T15:02:30Z

frontend/public/style/_overrides.scss

PatternFly's <Tabs> does not have an inset value that perfectly aligns the inset with the padding of <PageSection>. This is a bug? @nicolethoen, @kmcfaul

I'm asking about that. will report back

I'm being told it is a bug 👍🏻
Would you mind opening a bug in https://github.com/patternfly/patternfly/issues?
You can link to it in this override.

Done. Will also add a link to the bug here.

rhamilto · 2025-02-27T15:13:19Z

frontend/public/style/_overrides.scss

Relocating to the correct partial.

rhamilto · 2025-02-27T16:41:49Z

@logonoff, I've got an additional commit to update docs, but don't want to interrupt the current CI run by pushing it. Posting the diff here for your viewing pleasure. ;-)

doc.patch

rhamilto · 2025-02-27T17:10:39Z

/assign @logonoff
/assign @XiyunZhao

Follow-on to previously approved story, so assigning approvals:
/label px-approved
/label docs-approved

rhamilto · 2025-02-27T19:38:19Z

frontend/public/components/cluster-settings/cluster-settings.tsx

Add the border above the tabs since it lacks them and the standard is for pages with tabs to have the border.

To better match with PF I think that the PageHeading border should be removed here as well. This would better match with the PF mockup that was made for OCP as well:

Oh. I missed this one. I think I agree. Gonna discuss this one with the broader community.

Thinking we should tackle this as a follow on so as not to conflate the issues.

dynamic-demo-plugin/src/components/ListPage.tsx

logonoff · 2025-03-24T15:17:08Z

/lgtm

…eSection` component

Co-authored-by: logonoff <git@logonoff.co>

logonoff · 2025-03-24T15:46:57Z

/lgtm

openshift-ci · 2025-03-24T15:53:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~dynamic-demo-plugin/OWNERS~~ [rhamilto]
~~frontend/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff · 2025-03-24T20:48:12Z

/label acknowledge-critical-fixes-only

qe approval:

/assign @yapei

rhamilto · 2025-03-24T23:50:14Z

/retest

rhamilto · 2025-03-25T09:03:30Z

/retest

logonoff · 2025-03-25T15:07:13Z

/close

superseded by #14875

openshift-ci · 2025-03-25T15:07:25Z

@logonoff: Closed this PR.

Details

In response to this:

/close

superseded by #14875

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2025

openshift-ci bot requested review from avivtur and christoph-jerolimov February 27, 2025 14:34

rhamilto force-pushed the CONSOLE-4492 branch from 3b798ed to 4a21cae Compare February 27, 2025 14:35

rhamilto commented Feb 27, 2025

View reviewed changes

openshift-ci bot assigned logonoff and XiyunZhao Feb 27, 2025

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Feb 27, 2025

rhamilto commented Feb 27, 2025

View reviewed changes

logonoff reviewed Mar 24, 2025

View reviewed changes

dynamic-demo-plugin/src/components/ListPage.tsx Outdated Show resolved Hide resolved

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025

rhamilto and others added 12 commits March 24, 2025 11:43

Replace co-m-page__body with PatternFly's Flex component

276a1ed

Use PatternFly's PageBreadcrumb

f472a39

Replace div#app-content with PatternFly's Flex component

8b955fd

Replace co-m-pane__body and co-m-nav-title with PatternFly's `Pag…

401aa63

…eSection` component

Update docs

483aa62

Plugin fix

9790cbf

Update comment to include link to PatternFly bug

8638e08

Use isFilled prop instead of pf-v6-u-h-100

9d04f9e

Remove unnecessary nodes

5176d2e

Fix regression where actions can be misaligned

1202075

Fix Project Access content layout

cbf0b3d

Update dynamic-demo-plugin/src/components/ListPage.tsx

0bec5c1

Co-authored-by: logonoff <git@logonoff.co>

rhamilto force-pushed the CONSOLE-4492 branch from 7259746 to 0bec5c1 Compare March 24, 2025 15:45

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2025

adamviktora mentioned this pull request Mar 24, 2025

CNV-58317: remove co- classes which changed styling kubevirt-ui/kubevirt-plugin#2533

Merged

openshift-ci bot assigned yapei Mar 24, 2025

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 24, 2025

openshift-ci bot closed this Mar 25, 2025

CONSOLE-4492: Align spacing of page elements with PatternFly #14805

CONSOLE-4492: Align spacing of page elements with PatternFly #14805

Uh oh!

Conversation

rhamilto commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhamilto Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rhamilto commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhamilto commented Feb 27, 2025

Uh oh!

rhamilto Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logonoff Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

logonoff commented Mar 24, 2025

Uh oh!

logonoff commented Mar 24, 2025

Uh oh!

openshift-ci bot commented Mar 24, 2025

Uh oh!

logonoff commented Mar 24, 2025

Uh oh!

rhamilto commented Mar 24, 2025

Uh oh!

rhamilto commented Mar 25, 2025

Uh oh!

logonoff commented Mar 25, 2025

Uh oh!

openshift-ci bot commented Mar 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rhamilto commented Feb 27, 2025 •

edited

Loading

openshift-ci-robot commented Feb 27, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 27, 2025 •

edited by openshift-ci bot

Loading

rhamilto Feb 27, 2025 •

edited

Loading

rhamilto commented Feb 27, 2025 •

edited

Loading

rhamilto Feb 27, 2025 •

edited

Loading

logonoff Mar 3, 2025 •

edited

Loading