Monitoring: Add PromQL query browser page #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
openshift-ci-robot
requested review from
benjaminapetersen and
jeff-phillips-18
spadgett
reviewed
Apr 25, 2019
| <div className="row co-m-table-grid__head"> | ||
| <div className="col-xs-9 query-browser-metric__wrapper"> | ||
| <div className="query-browser-metric__color"></div> | ||
| SERIES |
Member
There was a problem hiding this comment.
nit: these should probably be Series and Value with text-transform: uppercase.
| <div className="col-xs-9 query-browser-metric__wrapper"> | ||
| <div className="query-browser-metric__color" style={{backgroundColor: graphColors[parseInt(i, 10) % graphColors.length]}}></div> | ||
| <div className="query-browser-metric__labels"> | ||
| {_.map(m.labels, (v, k) => `${k}="${v}",`).join('').replace(/,$/, '')} |
Member
There was a problem hiding this comment.
Does this do the same?
Suggested change
| {_.map(m.labels, (v, k) => `${k}="${v}",`).join('').replace(/,$/, '')} | |
| {_.map(m.labels, (v, k) => `${k}="${v}"`).join(',')} |
| </div>; | ||
|
|
||
| const QueryBrowserPage = () => { | ||
| const [metrics, setMetrics] = React.useState(getURLSearchParams().query); |
Member
There was a problem hiding this comment.
This looks like it's the wrong initial value?
Initial commit for the PromQL query browser page. Displays a graph for any PromQL query. You can edit the query and the graph will dynamically update. You can zoom and drag the graph to view different time spans. Shows the label keys and values for each time series plotted in the graph.
kyoto
force-pushed
the
query-browser-page
branch
from
b20102a to
31064e8
Compare
Member
Author
|
Thanks @spadgett. I addressed your comments and rebased. |
Member
Author
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit for the PromQL query browser page.
Displays a graph for any PromQL query. You can edit the query and the
graph will dynamically update.
You can zoom and drag the graph to view different time spans.
Shows the label keys and values for each time series plotted in the graph.
This PR aims to add the basic page functionality while minimizing conflicts with #1448.
QueryBrowserwill be reworked after that PR merges.The styling in the PR is kept simple since the mocks are still being finalized.