Skip to content

ODC-7802: Remove custom Drawer and Tabs from web-terminal#15077

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
logonoff:ODC-7802-webterminal
Jul 28, 2025
Merged

ODC-7802: Remove custom Drawer and Tabs from web-terminal#15077
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
logonoff:ODC-7802-webterminal

Conversation

@logonoff
Copy link
Copy Markdown
Member

@logonoff logonoff commented May 21, 2025 •
edited
Loading

https://issues.redhat.com/browse/ODC-7802

changes:

  • the copy/pasted PF tabs component in @console/app has been removed
  • the custom Drawer component based on react-draggable has been removed
  • you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
  • in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
  • a tooltip was added to the web terminal toggle button in the masthead

after:

image

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 21, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

  • the copy/pasted PF tabs component in @console/app has been removed
  • the custom Drawer component based on react-draggable has been removed
  • you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
  • in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
  • the terminal now animates when opening and closing
  • you can no longer resize the web terminal when it is minimized
  • a tooltip was added to the web terminal toggle button in the masthead

after:

image

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels May 21, 2025
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 21, 2025
@logonoff logonoff force-pushed the ODC-7802-webterminal branch 2 times, most recently from 74acc85 to a2ee144 Compare May 22, 2025 01:29
@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label May 22, 2025
@logonoff logonoff force-pushed the ODC-7802-webterminal branch 3 times, most recently from 293e48a to a39c616 Compare May 22, 2025 12:25
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

  • the copy/pasted PF tabs component in @console/app has been removed
  • the custom Drawer component based on react-draggable has been removed
  • you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
  • in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
  • the terminal now animates when opening and closing
  • you can no longer resize the web terminal when it is minimized
  • a tooltip was added to the web terminal toggle button in the masthead

after:

image

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yapei
Copy link
Copy Markdown
Contributor

yapei commented May 26, 2025 •
edited
Loading

Tested the PR and found two possible regressions

  • Minimize terminal will close all opened Terminals which I think should be unexpected, recording
  • command line terminal occupies the whole screen on mobile view, and there is no Minimize terminal button and not able to close the terminal recording

@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented May 28, 2025 •
edited
Loading

hi @yapei,

thanks for checking the PR! the first issue is definitely a regression, which should be fixed now. I also made further changes so that you can resize the web terminal even if it's minimized (like how it was before)

the second issue regarding the web terminal taking up the whole screen is unfortunately a design choice by PatternFly--in their drawer component any drawer will automatically take up the entire mobile viewport. because of this, you cannot minimize or resize drawers in mobile, so i intentionally removed the button because it would not work. we can consult with UX to see if disabling the button instead is better if you would like

code review:
/assign @rhamilto

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 28, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

  • the copy/pasted PF tabs component in @console/app has been removed
  • the custom Drawer component based on react-draggable has been removed
  • you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
  • in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
  • the terminal now animates when opening and closing
  • a tooltip was added to the web terminal toggle button in the masthead

after:

image

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yapei
Copy link
Copy Markdown
Contributor

yapei commented May 29, 2025

@logonoff

the second issue regarding the web terminal taking up the whole screen is unfortunately a design choice by PatternFly--in their drawer component any drawer will automatically take up the entire mobile viewport. because of this, you cannot minimize or resize drawers in mobile, so i intentionally removed the button because it would not work
sounds reasonable! thanks for confirmation

tested with the latest changes and now everything works well as expected
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 29, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 29, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

  • the copy/pasted PF tabs component in @console/app has been removed
  • the custom Drawer component based on react-draggable has been removed
  • you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
  • in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
  • the terminal now animates when opening and closing
  • a tooltip was added to the web terminal toggle button in the masthead

after:

image

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the ODC-7802-webterminal branch 3 times, most recently from dfecbc6 to baa4546 Compare June 7, 2025 15:55
@logonoff logonoff force-pushed the ODC-7802-webterminal branch 5 times, most recently from a2581d0 to 4fc9e4a Compare July 9, 2025 18:01
@logonoff logonoff force-pushed the ODC-7802-webterminal branch 10 times, most recently from a7d9d6e to fde3c13 Compare July 24, 2025 21:13
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 25, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

  • the copy/pasted PF tabs component in @console/app has been removed
  • the custom Drawer component based on react-draggable has been removed
  • you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
  • in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
  • a tooltip was added to the web terminal toggle button in the masthead

after:

image

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Copy Markdown
Member Author

logonoff commented Jul 25, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 25, 2025
logonoff and others added 3 commits July 25, 2025 10:27
@logonoff
ODC-7802: Remove custom Drawer from web-terminal
8dc997c
@logonoff
ODC-7802: Remove react-transition-group
5ead496
@logonoff @rhamilto @sanketpathak
ODC-7802: Fix broken e2e
e97756b 
big thanks to @rhamilto and @sanketpathak for the help!

Co-Authored-By: Robb Hamilton <895728+rhamilto@users.noreply.github.com>
Co-Authored-By: Sanket Pathak <spathak@redhat.com>
@logonoff logonoff force-pushed the ODC-7802-webterminal branch from fde3c13 to e97756b Compare July 25, 2025 14:28
@logonoff logonoff mentioned this pull request Jul 25, 2025
Closed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 26, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vikram-raj
vikram-raj reviewed Jul 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4744295 into openshift:main Jul 28, 2025
8 checks passed
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 28, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202507280816.p0.g4744295.assembly.stream.el9.
All builds following this will include this PR.

@logonoff logonoff deleted the ODC-7802-webterminal branch July 28, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@vikram-raj vikram-raj vikram-raj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhamilto rhamilto

@vikram-raj vikram-raj

@sanketpathak sanketpathak

@yapei yapei

@TheRealJon TheRealJon

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/olm Related to OLM component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@logonoff @openshift-ci-robot @yapei @sanketpathak @openshift-bot @vikram-raj @rhamilto @TheRealJon