Skip to content

Remove unused cluster-health component #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 2, 2019
Merged

Remove unused cluster-health component #1508

openshift-merge-robot merged 1 commit into from
May 2, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Apr 30, 2019

/cc @rhamilto

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2019
@spadgett
Copy link
Member Author

spadgett commented Apr 30, 2019

@TheRealJon fyi

rhamilto
rhamilto reviewed Apr 30, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humanizeNumber and Scalar are orphaned by this deletion. Remove them, too?

@TheRealJon
Copy link
Member

TheRealJon commented Apr 30, 2019

Definitely not humanizeNumber, I'm using it in #1448

@TheRealJon
Copy link
Member

TheRealJon commented Apr 30, 2019

I think the Scalar component could be refactored to be a chart title.

@spadgett spadgett force-pushed the remove-cluster-health branch from 62b07bf to c5c0082 Compare May 2, 2019 19:40
@spadgett
Copy link
Member Author

spadgett commented May 2, 2019

Thanks, updated to remove Scalar for now. I left humanizeNumber.

@rhamilto
Copy link
Member

rhamilto commented May 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.1 milestone May 2, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2031392 into openshift:master May 2, 2019
@spadgett spadgett deleted the remove-cluster-health branch May 2, 2019 21:33
@kyoto kyoto mentioned this pull request May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto left review comments

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@spadgett @TheRealJon @rhamilto @openshift-ci-robot @openshift-merge-robot