Skip to content

CONSOLE-4663: Replace Bootstrap .has-feedback with custom rule #15264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jul 15, 2025
Merged

CONSOLE-4663: Replace Bootstrap .has-feedback with custom rule #15264

openshift-merge-bot merged 1 commit into from
Jul 15, 2025

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 9, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4663 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2025
@rhamilto
Copy link
Member Author

rhamilto commented Jul 9, 2025

code approval:
/assign @logonoff
qe approval:
/assign @yapei

This is tech debt, so nothing for PX or docs to review.
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jul 9, 2025
rhamilto
rhamilto commented Jul 9, 2025
View reviewed changes
frontend/packages/pipelines-plugin/src/components/ListPage.tsx

type TextFilterProps = Omit<TextInputProps, 'type' | 'tabIndex'> & {
label?: string;
parentClassName?: string;
Copy link
Member Author

@rhamilto rhamilto Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used, so removing.

frontend/packages/pipelines-plugin/src/components/ListPage.tsx
<div className="co-text-filter">
<TextInput
{...otherInputProps}
className={css('co-text-filter', className)}
Copy link
Member Author

@rhamilto rhamilto Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

className is unused, so removing.

frontend/public/components/factory/list-page.tsx

type TextFilterProps = Omit<TextInputProps, 'type' | 'tabIndex'> & {
label?: string;
parentClassName?: string;
Copy link
Member Author

@rhamilto rhamilto Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ListPage.tsx above is a duplicate of this file. Sigh.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yapei
Copy link
Contributor

yapei commented Jul 11, 2025

  • did some regression testing on resource list page filtering(including Pipelines pages), filter by Name and Label, check Label suggestions, no outstanding issues found
Screenshot 2025-07-11 at 2 37 16 PM Screenshot 2025-07-11 at 2 41 19 PM /label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 11, 2025 •
edited by openshift-ci bot
Loading

@rhamilto: This pull request references CONSOLE-4663 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff
logonoff approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8ed12e7 into openshift:main Jul 15, 2025
7 checks passed
@rhamilto rhamilto deleted the CONSOLE-4663 branch July 15, 2025 21:19
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 16, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202507152308.p0.g8ed12e7.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@kyoto kyoto Awaiting requested review from kyoto

1 more reviewer

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yapei yapei

@logonoff logonoff

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/pipelines Related to pipelines-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @yapei @openshift-bot @logonoff