CONSOLE-4667: Add ResourceDataView component and related code

[vojtechszocs]

This PR follows up on #14897 and #15057 by introducing a reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow-up PRs to put this component into use.

Thanks to @rhamilto for testing the new component in CronTab plugin so we can fix any immediate issues.

[openshift-ci-robot]

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Summary

This PR follows up on #14897 and #15057 by introducing reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow up PRs to put this component into use.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This PR follows up on #14897 and #15057 by introducing reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow up PRs to put this component into use.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vojtechszocs]

/retest

[rhamilto]

A few observations from when I applied this code in openshift/console-crontab-plugin#45

[rhamilto]

This results in the actions column getting sorting functionality, which is not desired. Sorting should be optional on a per column basis.

[rhamilto]

And I believe sorting is broken for all but the first column, but even there the header doesn't correctly indicate the sort direction.

[rhamilto]

openshift/console-crontab-plugin@87da69a makes sorting optional.

Still need to troubleshoot the sorting issues in useResourceDataViewSort.

[vojtechszocs]

Note that the hard-coded sortBy object was present in the original DataView PoC code:

• CONSOLE-4529: POC PodList using DataView PF extension #14897 - file frontend/public/components/data-view-poc/DataViewPodList.tsx line 489
• [WIP] Data view poc #15057 - file frontend/public/components/data-view-poc/DataViewPodList.tsx line 513

sortBy: {
  defaultDirection: SortByDirection.asc,
  direction: SortByDirection.asc,
  index: 0,
}

I think that fixing sorting bugs (beyond any immediate issues) can be done as a follow-up.

This PR was supposed to introduce a reusable ResourceDataView component by refactoring and restructuring the original DataView PoC code.

[rhamilto]

ResourceDataView.patch

includes the correct fix so the filters dropdown correctly honors hideNameLabelFilters and hideLabelFilter props.

[rhamilto]

Oye. One more change.

useResourceDataViewSort.patch

[rhamilto]

It occurs to me those patches won't apply cleanly since my directory structure in the CronTab plugin doesn't match, but at least they're there.

[rhamilto]

It occurs to me those patches won't apply cleanly since my directory structure in the CronTab plugin doesn't match, but at least they're there.

I think this patch should work (it should contain all the changes we discussed yesterday).

DataView.patch

[openshift-ci-robot]

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This PR follows up on #14897 and #15057 by introducing a reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow-up PRs to put this component into use.

Thanks to @rhamilto for testing the new component so we can fix any immediate issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This PR follows up on #14897 and #15057 by introducing a reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow-up PRs to put this component into use.

Thanks to @rhamilto for testing the new component in CronTab plugin so we can fix any immediate issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

@vojtechszocs, you need to run yarn i18n and commit the diff.

[rhamilto]

code approval:
/assign @jhadvig
qe approval:
/assign @yapei
px approval:
/assign @sferich888
docs approval:
/assign @jseseCCS

[openshift-ci]

@rhamilto: GitHub didn't allow me to assign the following users: jseseCCS.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

code approval:
/assign @jhadvig
qe approval:
/assign @yapei
px approval:
/assign @sferich888
docs approval:
/assign @jseseCCS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yapei]

Shall we add unit test for the new component?

[vojtechszocs]

@yapei I think we can skip adding unit tests for this component at this point in time.

The main goal of this PR was to refactor original DataView PoC code from #14897 and #15057 without putting this component into any use. This is the initial step towards using PatternFly DataView code in Console.

Any immediate issues found by @rhamilto via CronTab plugin testing should be covered in this PR. Once this PR merges, the next step should be putting this component into use on select Console data tables and resolve any other issues we find along the way.

Once we're confident about the API (props) for this component, we can add unit tests for it.

[vojtechszocs]

@rhamilto Updated i18n - see the last commit.

[rhamilto]

/lgtm

Will address the remaining issues in 08a353c or additional follow ons.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

Adding labels since this is foundational code that is not yet in use. Approvals will be done in #15469 where this code is applied.

/label docs-approved
/label px-approved

[rhamilto]

/test okd-scos-e2e-aws-ovn

[rhamilto]

@yapei, can we punt on the unit test for the time being?

[rhamilto]

@yapei, can we punt on the unit test for the time being?

If so, can you add the remaining labels (qe-approved and verified)?

[yapei]

verified the changes in #15469, no issues found
/verified by @yapei
/label qe-approved

[openshift-ci-robot]

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This PR follows up on #14897 and #15057 by introducing a reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow-up PRs to put this component into use.

Thanks to @rhamilto for testing the new component in CronTab plugin so we can fix any immediate issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

verified the changes in #15469, no issues found
/verified by @yapei
/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5981a88 and 2 for PR HEAD 7af299a in total

[rhamilto]

/test frontend

[openshift-ci]

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.