Skip to content

CONSOLE-4668: Implement new OLM v1 catalog service architecture #15376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 9 commits into from
Oct 31, 2025
Merged

CONSOLE-4668: Implement new OLM v1 catalog service architecture #15376

openshift-merge-bot merged 9 commits into from
Oct 31, 2025

Conversation

@TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Aug 7, 2025 •
edited
Loading

Implements new catalog service for OLM with catalogd backend integration including:

  • New catalog client for fetching FBC data from catalogd
  • Caching layer for catalog data with expiration management
  • Console catalog item transformation from operator registry format
  • Updated frontend API endpoints to /api/olm/* namespace:
    • /api/list-operands → /api/olm/list-operands
    • /api/check-package-manifest → /api/olm/check-package-manifests
    • Added /api/olm/catalog-items endpoint
  • User context extraction utilities for request handling
  • Comprehensive test coverage for catalog client and service components

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2025 •
edited by openshift-ci bot
Loading

@TheRealJon: This pull request references CONSOLE-4668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2025
@openshift-ci openshift-ci bot added component/backend Related to backend component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared labels Aug 7, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2025
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 19, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2025
@trgeiger trgeiger mentioned this pull request Sep 5, 2025
Merged
@TheRealJon TheRealJon force-pushed the CONSOLE-4668 branch 4 times, most recently from 1097dcd to 69b1e48 Compare September 9, 2025 20:17
@TheRealJon
Copy link
Member Author

TheRealJon commented Sep 9, 2025

/hold

Merge after #15466

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2025
@TheRealJon TheRealJon marked this pull request as ready for review September 9, 2025 21:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2025
@openshift-ci openshift-ci bot requested review from cajieh and jhadvig September 9, 2025 21:34
@TheRealJon TheRealJon force-pushed the CONSOLE-4668 branch 2 times, most recently from 1d9f7bf to 2555c0f Compare September 11, 2025 20:15
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@TheRealJon
Copy link
Member Author

TheRealJon commented Oct 23, 2025

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 23, 2025
@TheRealJon TheRealJon force-pushed the CONSOLE-4668 branch 3 times, most recently from 3f6b764 to 053a898 Compare October 24, 2025 18:04
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Oct 28, 2025

/assign @Leo6Leo
for review tracking purposes

@TheRealJon @claude
Refactor catalog caching to use per-catalog last modified tracking
61e58c7 
Improves HTTP caching behavior by tracking upstream last-modified times
separately for each catalog, preventing unnecessary refetches when one
catalog is removed. Makes CacheLastModified nullable to properly handle
initial state, and adds ModifiedSince helper for consistent If-Modified-Since
header validation across handlers.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@yapei
Copy link
Contributor

yapei commented Oct 29, 2025

verified the latest changes both in cluster-bot cluster and locally
/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

verified the latest changes both in cluster-bot cluster and locally
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon
Copy link
Member Author

TheRealJon commented Oct 29, 2025

/retest

@TheRealJon TheRealJon mentioned this pull request Oct 29, 2025
Merged
jhadvig
jhadvig approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @TheRealJon 🤘 Thank you so much.
We are one step closed 👍

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, jseseCCS, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member

jhadvig commented Oct 30, 2025

/label plugin-api-approved
/retest

@openshift-ci openshift-ci bot added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Oct 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2025

/retest-required

Remaining retests: 0 against base HEAD 38fa442 and 2 for PR HEAD 61e58c7 in total

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Oct 30, 2025

The PR looks great to me as well! @TheRealJon For future iterations, a quick suggestion: Pushing new commits incrementally instead of using force-push will make it much faster to follow the changes and approve the next version.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 1e2f633 and 1 for PR HEAD 61e58c7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2025

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 01bb2ef into openshift:main Oct 31, 2025
7 of 8 checks passed
@TheRealJon TheRealJon deleted the CONSOLE-4668 branch October 31, 2025 13:35
@krishagarwal278 krishagarwal278 mentioned this pull request Dec 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@cajieh cajieh Awaiting requested review from cajieh

+2 more reviewers

@Leo6Leo Leo6Leo Leo6Leo requested changes

@jseseCCS jseseCCS jseseCCS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sferich888 sferich888

@jhadvig jhadvig

@yapei yapei

@Leo6Leo Leo6Leo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/olm Related to OLM component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer px-approved Signifies that Product Support has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@TheRealJon @openshift-ci-robot @yapei @sferich888 @Leo6Leo @jhadvig @jseseCCS @openshift-merge-robot