Skip to content

CONSOLE-4698: Enable SNC to true for frontend/console-app/components/volume-modes/snapshots and user preferences #15419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 4 commits into from
Sep 13, 2025
Merged

CONSOLE-4698: Enable SNC to true for frontend/console-app/components/volume-modes/snapshots and user preferences #15419

openshift-merge-bot merged 4 commits into from
Sep 13, 2025

Conversation

@krishagarwal278
Copy link
Member

@krishagarwal278 krishagarwal278 commented Aug 19, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 19, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2025 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4698 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Aug 19, 2025

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 19, 2025
@openshift-ci openshift-ci bot requested review from TheRealJon and rhamilto August 19, 2025 17:55
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Aug 19, 2025
@yanpzhan
Copy link
Contributor

yanpzhan commented Aug 21, 2025 •
edited
Loading

Local tsc check passed against the files in pr code and regression test passed on cluster launched against the pr.
/label qe-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@yanpzhan: The label(s) /label qe-approved. cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, plugin-api-approved, plugin-api-changed, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

Local tsc check passed against the files in pr code and regression test passed on cluster launched against the pr.
/label qe-approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yanpzhan
Copy link
Contributor

yanpzhan commented Aug 21, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 21, 2025 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4698 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/sdk Related to console-plugin-sdk plugin-api-changed Categorizes a PR as containing plugin API changes labels Aug 21, 2025
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin labels Aug 26, 2025
rhamilto
rhamilto reviewed Aug 26, 2025
View reviewed changes
frontend/packages/console-dynamic-plugin-sdk/src/extensions/console-types.ts Outdated
annotations?: { [key: string]: string };
clusterName?: string;
creationTimestamp?: string;
creationTimestamp?: string | number | Date;
Copy link
Member

@rhamilto rhamilto Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused by this. creationTimestamp is a string per https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Aug 26, 2025

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 26, 2025
@openshift-ci openshift-ci bot added the component/topology Related to topology label Aug 27, 2025
@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Aug 29, 2025

/retest

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Aug 29, 2025

//cc @rhamilto

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Sep 1, 2025

/retest

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Sep 2, 2025

//cc @rhamilto

@openshift-ci openshift-ci bot added component/gitops Related to gitops-plugin component/insights Related to insights plugin component/shared Related to console-shared labels Sep 3, 2025
@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Sep 8, 2025

/verified later @yapei @yanpzhan

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 8, 2025

@krishagarwal278: This PR has been marked to be verified later by @yapei @yanpzhan.

Details

In response to this:

/verified later @yapei @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member

rhamilto commented Sep 12, 2025

/lgtm

@rhamilto rhamilto added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Sep 12, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishagarwal278, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2025

/retest-required

Remaining retests: 0 against base HEAD fd95953 and 2 for PR HEAD e671710 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2025

@krishagarwal278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b33ff3e into openshift:main Sep 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@vojtechszocs vojtechszocs

@rhamilto rhamilto

@spadgett spadgett

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer plugin-api-changed Categorizes a PR as containing plugin API changes px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@krishagarwal278 @openshift-ci-robot @yanpzhan @rhamilto @vojtechszocs @spadgett @jhadvig