OCPBUGS-60886: use `window.crypto` in `useGetUserSettingConfigMap` #15432

vikram-raj · 2025-08-26T12:23:52Z

The createHash function has been used from the crypto package, which causes the console to break with a TypeError.

openshift-ci-robot · 2025-08-26T12:23:58Z

@vikram-raj: This pull request references Jira Issue OCPBUGS-60886, which is invalid:

expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The createHash function has been used from the crypto package, which causes the console to break with a TypeError.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vikram-raj · 2025-08-26T12:24:27Z

/jira refresh

openshift-ci-robot · 2025-08-26T12:24:36Z

@vikram-raj: This pull request references Jira Issue OCPBUGS-60886, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2025-08-26T12:35:42Z

frontend/packages/console-shared/src/hooks/useGetUserSettingConfigMap.ts

@@ -1,5 +1,5 @@
-import { createHash } from 'crypto';
 import { useMemo } from 'react';
+import { createHash } from 'crypto-browserify';


per OCPBUGS-44505 we are trying to remove crypto-browserify. can you try using the window.crypto object?

Sure, I wasn't aware of that. Thanks.

I need to revisit that, still hasn't figured out the CI failures after the migration to window.crypto

logonoff · 2025-09-18T14:41:46Z

/retitle OCPBUGS-60886: use window.crypto from useGetUserSettingConfigMap
/label tide/merge-method-squash

logonoff · 2025-09-18T14:44:05Z

/retitle OCPBUGS-60886: use window.crypto in useGetUserSettingConfigMap

logonoff

/verified by useGetUserSettingConfigMap.spec.ts
/lgtm

logonoff · 2025-09-18T14:52:17Z

/verified by useGetUserSettingConfigMap.spec.ts

openshift-ci-robot · 2025-09-18T14:52:29Z

@logonoff: This PR has been marked as verified by useGetUserSettingConfigMap.spec.ts.

Details

In response to this:

/verified by useGetUserSettingConfigMap.spec.ts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-18T19:50:11Z

/retest-required

Remaining retests: 0 against base HEAD 6098ca4 and 2 for PR HEAD d3082df in total

openshift-ci-robot · 2025-09-18T23:53:56Z

/retest-required

Remaining retests: 0 against base HEAD 6efa508 and 1 for PR HEAD d3082df in total

openshift-ci-robot · 2025-09-19T05:03:40Z

/retest-required

Remaining retests: 0 against base HEAD 6efa508 and 2 for PR HEAD d3082df in total

openshift-ci-robot · 2025-09-19T18:42:28Z

/retest-required

Remaining retests: 0 against base HEAD 11d1f43 and 1 for PR HEAD d3082df in total

openshift-ci-robot · 2025-09-20T01:19:28Z

/retest-required

Remaining retests: 0 against base HEAD b16f659 and 0 for PR HEAD d3082df in total

openshift-ci-robot · 2025-09-20T05:19:22Z

/hold

Revision d3082df was retested 3 times: holding

vikram-raj · 2025-09-22T04:53:22Z

/retest

vikram-raj · 2025-09-23T04:53:23Z

/retest

vikram-raj · 2025-09-29T07:09:06Z

/retest

vikram-raj · 2025-10-14T08:18:30Z

/retest

vikram-raj · 2025-10-14T17:21:13Z

/unhold

openshift-ci-robot · 2025-10-14T19:28:32Z

/retest-required

Remaining retests: 0 against base HEAD 9ec1a9d and 2 for PR HEAD d3082df in total

openshift-ci-robot · 2025-10-15T05:28:12Z

/retest-required

Remaining retests: 0 against base HEAD 85c59f9 and 1 for PR HEAD d3082df in total

logonoff · 2025-10-15T15:10:52Z

/verified by useGetUserSettingConfigMap.spec.ts
/lgtm

openshift-ci-robot · 2025-10-15T15:11:05Z

@logonoff: This PR has been marked as verified by useGetUserSettingConfigMap.spec.ts.

Details

In response to this:

/verified by useGetUserSettingConfigMap.spec.ts
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-15T15:11:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-10-15T15:50:57Z

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-10-15T15:56:15Z

@vikram-raj: Jira Issue Verification Checks: Jira Issue OCPBUGS-60886
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-60886 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

The createHash function has been used from the crypto package, which causes the console to break with a TypeError.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…penshift#15432) * import createHash from crypto-browserify * use window.crypto * fix e2e add-flow-ci.feature

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 26, 2025

openshift-ci bot requested review from Mylanos, sanketpathak and yapei August 26, 2025 12:24

openshift-ci bot added component/dev-console Related to dev-console component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2025

logonoff suggested changes Aug 26, 2025

View reviewed changes

vikram-raj force-pushed the ocpbugs-60886 branch from 4217746 to d3082df Compare September 18, 2025 13:48

vikram-raj requested a review from logonoff September 18, 2025 13:57

openshift-ci bot changed the title ~~OCPBUGS-60886: import createHash from crypto-browserify~~ OCPBUGS-60886: use window.crypto from useGetUserSettingConfigMap Sep 18, 2025

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 18, 2025

openshift-ci bot changed the title ~~OCPBUGS-60886: use window.crypto from useGetUserSettingConfigMap~~ OCPBUGS-60886: use window.crypto in useGetUserSettingConfigMap Sep 18, 2025

logonoff approved these changes Sep 18, 2025

View reviewed changes

openshift-ci bot assigned logonoff Sep 18, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 18, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025

vikram-raj added 3 commits October 15, 2025 12:55

import createHash from crypto-browserify

eb66c6b

use window.crypto

cb53616

fix e2e add-flow-ci.feature

df3895c

vikram-raj force-pushed the ocpbugs-60886 branch from d3082df to df3895c Compare October 15, 2025 08:55

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Oct 15, 2025

vikram-raj requested a review from logonoff October 15, 2025 15:08

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 15, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025

openshift-merge-bot bot merged commit a991638 into openshift:main Oct 15, 2025
8 checks passed

Leo6Leo pushed a commit to Leo6Leo/console that referenced this pull request Oct 15, 2025

OCPBUGS-60886: use window.crypto in useGetUserSettingConfigMap (o…

4b18db8

…penshift#15432) * import createHash from crypto-browserify * use window.crypto * fix e2e add-flow-ci.feature

vikram-raj deleted the ocpbugs-60886 branch October 22, 2025 13:20

krishagarwal278 mentioned this pull request Dec 3, 2025

OCPBUGS-66105: Lack of kebab list on projects list page for normal user #15801

Merged

OCPBUGS-60886: use window.crypto in useGetUserSettingConfigMap #15432

OCPBUGS-60886: use window.crypto in useGetUserSettingConfigMap #15432

Uh oh!

Conversation

vikram-raj commented Aug 26, 2025

Uh oh!

openshift-ci-robot commented Aug 26, 2025

Uh oh!

vikram-raj commented Aug 26, 2025

Uh oh!

openshift-ci-robot commented Aug 26, 2025

Uh oh!

logonoff Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

vikram-raj Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Mylanos Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

logonoff commented Sep 18, 2025

Uh oh!

logonoff commented Sep 18, 2025

Uh oh!

logonoff left a comment

Choose a reason for hiding this comment

Uh oh!

logonoff commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 18, 2025

Uh oh!

openshift-ci-robot commented Sep 19, 2025

Uh oh!

openshift-ci-robot commented Sep 19, 2025

Uh oh!

openshift-ci-robot commented Sep 20, 2025

Uh oh!

openshift-ci-robot commented Sep 20, 2025

Uh oh!

vikram-raj commented Sep 22, 2025

Uh oh!

vikram-raj commented Sep 23, 2025

Uh oh!

vikram-raj commented Sep 29, 2025

Uh oh!

vikram-raj commented Oct 14, 2025

Uh oh!

vikram-raj commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

logonoff commented Oct 15, 2025

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

openshift-ci bot commented Oct 15, 2025

Uh oh!

openshift-ci bot commented Oct 15, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

OCPBUGS-60886: use `window.crypto` in `useGetUserSettingConfigMap` #15432

OCPBUGS-60886: use `window.crypto` in `useGetUserSettingConfigMap` #15432